Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2614033003: Make subclasses of AbstractContextTest asynchronous. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make subclasses of AbstractContextTest asynchronous. As a preliminary step before duplicating them for the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2f48ccf58f96bfdeec0aaa5f33f2ced4846ed08

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1687 lines, -1684 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 12 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 244 chunks +252 lines, -252 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 249 chunks +253 lines, -252 lines 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 17 chunks +34 lines, -34 lines 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 5 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 13 chunks +26 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_test.dart View 16 chunks +23 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_unit_test.dart View 56 chunks +147 lines, -146 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 8 chunks +17 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 73 chunks +109 lines, -109 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 127 chunks +219 lines, -219 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 34 chunks +61 lines, -61 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 76 chunks +145 lines, -145 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 34 chunks +48 lines, -48 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 9 chunks +14 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 9 chunks +18 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 25 chunks +41 lines, -41 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 26 chunks +59 lines, -59 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 10 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 38 chunks +39 lines, -39 lines 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 41 chunks +80 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-05 21:48:01 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-05 22:20:12 UTC) #2
scheglov
3 years, 11 months ago (2017-01-05 22:21:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d2f48ccf58f96bfdeec0aaa5f33f2ced4846ed08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698