third_party/WebKit/Source/core/page/WindowFeatures.cpp - Issue 2614033002: Migrate WTF::Vector::append() to ::push_back() [part 11 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/WindowFeatures.cpp

Issue 2614033002: Migrate WTF::Vector::append() to ::push_back() [part 11 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/WindowFeatures.cpp

diff --git a/third_party/WebKit/Source/core/page/WindowFeatures.cpp b/third_party/WebKit/Source/core/page/WindowFeatures.cpp

index f1d78f9e4595cc69d89b2d6e06006575423c684e..4e299ee87e0273e8d1d314edca74a275b4393b71 100644

--- a/third_party/WebKit/Source/core/page/WindowFeatures.cpp

+++ b/third_party/WebKit/Source/core/page/WindowFeatures.cpp

@@ -169,7 +169,7 @@ void WindowFeatures::setWindowFeature(const String& keyString,

} else if (keyString == "noopener") {

noopener = true;

} else if (value == 1) {

- additionalFeatures.append(keyString);

+ additionalFeatures.push_back(keyString);

}