Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 261403003: Removes usage of NavigationEntry from favicon_handler.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes v2. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.h
diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h
index 9450b0c4e928db594fc1eb76b4ed783df0fb4df4..b1df49777bad598ecb2c8e4a400231a7b4437582 100644
--- a/chrome/browser/favicon/favicon_tab_helper.h
+++ b/chrome/browser/favicon/favicon_tab_helper.h
@@ -19,6 +19,10 @@ namespace gfx {
class Image;
}
+namespace content {
+struct FaviconStatus;
+}
+
class GURL;
class FaviconHandler;
class Profile;
@@ -68,10 +72,16 @@ class FaviconTabHelper : public content::WebContentsObserver,
void SaveFavicon();
// FaviconDriver methods.
- virtual content::NavigationEntry* GetActiveEntry() OVERRIDE;
virtual int StartDownload(const GURL& url, int max_bitmap_size) OVERRIDE;
virtual void NotifyFaviconUpdated(bool icon_url_changed) OVERRIDE;
virtual bool IsOffTheRecord() OVERRIDE;
+ virtual const gfx::Image GetActiveFaviconImage() OVERRIDE;
+ virtual const GURL GetActiveFaviconURL() OVERRIDE;
+ virtual bool GetActiveFaviconValidity() OVERRIDE;
+ virtual const GURL GetActiveURL() OVERRIDE;
+ virtual void SetActiveFaviconImage(gfx::Image image) OVERRIDE;
+ virtual void SetActiveFaviconURL(GURL url) OVERRIDE;
+ virtual void SetActiveFaviconValidity(bool validity) OVERRIDE;
// Favicon download callback.
void DidDownloadFavicon(
@@ -97,6 +107,9 @@ class FaviconTabHelper : public content::WebContentsObserver,
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) OVERRIDE;
+ // Helper method that returns the active navigation entry's favicon.
+ content::FaviconStatus& GetFaviconStatus();
+
Profile* profile_;
std::vector<content::FaviconURL> favicon_urls_;
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698