Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2614023006: [ios] Removed -[CRWWebDelegate openURLWithParams:]. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index dac801e1c4f1db0c0e1a3326758002f4ff205054..72d4d0632754bc7f52bc4572502e726c50074b3d 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1374,34 +1374,6 @@ void AddNetworkClientFactoryOnIOThread(
}
}
-- (void)openURLWithParams:(const web::WebState::OpenURLParams&)params {
- switch (params.disposition) {
- case WindowOpenDisposition::NEW_FOREGROUND_TAB:
- case WindowOpenDisposition::NEW_BACKGROUND_TAB:
- [parentTabModel_
- insertOrUpdateTabWithURL:params.url
- referrer:params.referrer
- transition:params.transition
- windowName:nil
- opener:self
- openedByDOM:NO
- atIndex:TabModelConstants::kTabPositionAutomatically
- inBackground:(params.disposition ==
- WindowOpenDisposition::NEW_BACKGROUND_TAB)];
- break;
- case WindowOpenDisposition::CURRENT_TAB: {
- web::NavigationManager::WebLoadParams loadParams(params.url);
- loadParams.referrer = params.referrer;
- loadParams.transition_type = params.transition;
- loadParams.is_renderer_initiated = params.is_renderer_initiated;
- self.navigationManager->LoadURLWithParams(loadParams);
- } break;
- default:
- NOTIMPLEMENTED();
- break;
- };
-}
-
- (BOOL)openExternalURL:(const GURL&)url linkClicked:(BOOL)linkClicked {
if (!externalAppLauncher_.get())
externalAppLauncher_.reset([[ExternalAppLauncher alloc] init]);
« no previous file with comments | « no previous file | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698