Change GN debug builds to use -O2, which is the value used by GYP.

Change GN debug builds to use -O2, which is the value used by GYP.

Running the language tests in debug mode, I got the following times
GYP -O2 1:50
GN -O1 4:48
GN -O2 1:55

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/ccd6cc7fc5634ee170d3aed5cdfd4e27d954b783

[rmacnak, 2017-01-06 00:19:45]

rmacnak@google.com changed reviewers:
+ zra@google.com

[rmacnak, 2017-01-06 00:26:59]

This causes the Profiler_XX tests to fail with frames shifted by one, so it
should probably wait for Siva's stack walker change.

[zra, 2017-01-06 16:00:02]

We should also change here:

https://github.com/dart-lang/sdk/blob/master/build/config/compiler/BUILD.gn#L748

To pick up things that aren't under dart_config

lgtm after Siva's fix lands.

[hausner, 2017-01-06 16:03:25]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2017-01-06 16:03:25]

Would be interested to compare the speed of test suites after this change. I
noticed yesterday that GH debug builds take more than twice as long to finish
the test suites than GYP debug builds.

[hausner, 2017-01-06 16:03:56]

Ok, now that I read the whole CL message: thank you! :-)

[jensj, 2017-01-09 13:28:03]

jensj@google.com changed reviewers:
+ jensj@google.com

[jensj, 2017-01-09 13:28:03]

Reading the Dart Gardening Log I assume this will fix the timeouts for

	co19/Language/Types/Interface_Types/subtype_t27
	co19/Language/Types/Interface_Types/subtype_t28
	co19/LibTest/collection/ListMixin/ListMixin_class_A01_t02

in precomp-debug config. For now I marked them as slow
(https://codereview.chromium.org/2620613004/), but they should probably be
unmarked again once this is committed.

[rmacnak, 2017-01-09 17:09:19]

On 2017/01/09 13:28:03, jensj wrote:
> Reading the Dart Gardening Log I assume this will fix the timeouts for
> 
> 	co19/Language/Types/Interface_Types/subtype_t27
> 	co19/Language/Types/Interface_Types/subtype_t28
> 	co19/LibTest/collection/ListMixin/ListMixin_class_A01_t02
> 
> in precomp-debug config. For now I marked them as slow
> (https://codereview.chromium.org/2620613004/), but they should probably be
> unmarked again once this is committed.

Changed the other O1 and suppressing profiler failures with
https://github.com/dart-lang/sdk/issues/28304

[rmacnak, 2017-01-09 17:09:45]

Description was changed from

==========
Change GN debug builds to use -O2, which is the value used by GYP.

Running the language tests in debug mode, I got the following times
GYP -O2 1:50
GN -O1 4:48
GN -O2 1:55
==========

to

==========
Change GN debug builds to use -O2, which is the value used by GYP.

Running the language tests in debug mode, I got the following times
GYP -O2 1:50
GN -O1 4:48
GN -O2 1:55

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ccd6cc7fc5634ee170d3aed5cdfd4e27d954b783
==========

[rmacnak, 2017-01-09 17:09:46]

Committed patchset #2 (id:20001) manually as
ccd6cc7fc5634ee170d3aed5cdfd4e27d954b783 (presubmit successful).