Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 2614002: Enable attributes to display and set properly. (Closed)

Created:
10 years, 6 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, gauravsh
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Enable attributes to display and set properly.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -80 lines) Patch
M src/platform/vboot_reference/utility/cgpt/cgpt.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/cgpt.c View 3 chunks +3 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/cgpt_add_modify_delete.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/cgpt_attribute.c View 5 chunks +20 lines, -23 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/cgpt_show.c View 7 chunks +61 lines, -47 lines 1 comment Download
M src/platform/vboot_reference/vboot_firmware/lib/cgptlib/cgptlib.c View 1 chunk +4 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/cgptlib_internal.h View 1 chunk +7 lines, -6 lines 0 comments Download
M src/platform/vboot_reference/vboot_firmware/lib/cgptlib/include/gpt.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Richardson
10 years, 6 months ago (2010-06-03 22:22:05 UTC) #1
Randall Spangler
10 years, 6 months ago (2010-06-03 22:29:50 UTC) #2
lgtm

http://codereview.chromium.org/2614002/diff/1/6
File src/platform/vboot_reference/utility/cgpt/cgpt_show.c (right):

http://codereview.chromium.org/2614002/diff/1/6#newcode148
src/platform/vboot_reference/utility/cgpt/cgpt_show.c:148:
CGPT_ATTRIBUTE_TRIES_OFFSET;
Should these line up with the ( above?

Powered by Google App Engine
This is Rietveld 408576698