Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3068)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 2613903002: The great shader refactor: Move all programs to a common cache (Closed)
Patch Set: Incorporate review feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/program_binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index 5098e244fccecede2c66c83b5b9aa4755dd7db81..f1eaae37ea61f1f068e76fd0fe1573645d9c51e9 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -384,95 +384,85 @@ class GLRendererShaderTest : public GLRendererTest {
void TestRenderPassProgram(TexCoordPrecision precision,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_program_[precision][blend_mode]);
- EXPECT_EQ(renderer_->render_pass_program_[precision][blend_mode].program(),
- renderer_->program_shadow_);
+ const Program* program = renderer_->GetProgramIfInitialized(
+ ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, NO_AA,
+ NO_MASK, false, false));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassColorMatrixProgram(TexCoordPrecision precision,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_color_matrix_program_[precision][blend_mode]);
- EXPECT_EQ(
- renderer_->render_pass_color_matrix_program_[precision][blend_mode]
- .program(),
- renderer_->program_shadow_);
+ const Program* program = renderer_->GetProgramIfInitialized(
+ ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, NO_AA,
+ NO_MASK, false, true));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassMaskProgram(TexCoordPrecision precision,
SamplerType sampler,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_mask_program_[precision]
- [sampler]
- [blend_mode]
- [NO_MASK]);
- EXPECT_EQ(
- renderer_->render_pass_mask_program_[precision]
- [sampler]
- [blend_mode]
- [NO_MASK].program(),
- renderer_->program_shadow_);
+ const Program* program =
+ renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
+ precision, sampler, blend_mode, NO_AA, HAS_MASK, false, false));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgram(TexCoordPrecision precision,
SamplerType sampler,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(&renderer_->render_pass_mask_color_matrix_program_
- [precision][sampler][blend_mode][NO_MASK]);
- EXPECT_EQ(renderer_->render_pass_mask_color_matrix_program_
- [precision][sampler][blend_mode][NO_MASK].program(),
- renderer_->program_shadow_);
+ const Program* program =
+ renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
+ precision, sampler, blend_mode, NO_AA, HAS_MASK, false, true));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassProgramAA(TexCoordPrecision precision,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_->render_pass_program_aa_[precision][blend_mode]);
- EXPECT_EQ(
- renderer_->render_pass_program_aa_[precision][blend_mode].program(),
- renderer_->program_shadow_);
+ const Program* program = renderer_->GetProgramIfInitialized(
+ ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, USE_AA,
+ NO_MASK, false, false));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassColorMatrixProgramAA(TexCoordPrecision precision,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_
- ->render_pass_color_matrix_program_aa_[precision][blend_mode]);
- EXPECT_EQ(
- renderer_->render_pass_color_matrix_program_aa_[precision][blend_mode]
- .program(),
- renderer_->program_shadow_);
+ const Program* program = renderer_->GetProgramIfInitialized(
+ ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, USE_AA,
+ NO_MASK, false, true));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassMaskProgramAA(TexCoordPrecision precision,
SamplerType sampler,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(
- &renderer_
- ->render_pass_mask_program_aa_
- [precision][sampler][blend_mode][NO_MASK]);
- EXPECT_EQ(
- renderer_->render_pass_mask_program_aa_[precision][sampler][blend_mode]
- [NO_MASK].program(),
- renderer_->program_shadow_);
+ const Program* program =
+ renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
+ precision, sampler, blend_mode, USE_AA, HAS_MASK, false, false));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgramAA(TexCoordPrecision precision,
SamplerType sampler,
BlendMode blend_mode) {
- EXPECT_PROGRAM_VALID(&renderer_->render_pass_mask_color_matrix_program_aa_
- [precision][sampler][blend_mode][NO_MASK]);
- EXPECT_EQ(renderer_->render_pass_mask_color_matrix_program_aa_
- [precision][sampler][blend_mode][NO_MASK].program(),
- renderer_->program_shadow_);
+ const Program* program =
+ renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
+ precision, sampler, blend_mode, USE_AA, HAS_MASK, false, true));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
void TestSolidColorProgramAA() {
- EXPECT_PROGRAM_VALID(&renderer_->solid_color_program_aa_);
- EXPECT_EQ(renderer_->solid_color_program_aa_.program(),
- renderer_->program_shadow_);
+ const Program* program =
+ renderer_->GetProgramIfInitialized(ProgramKey::SolidColor(USE_AA));
+ EXPECT_PROGRAM_VALID(program);
+ EXPECT_EQ(program->program(), renderer_->program_shadow_);
}
RendererSettings settings_;
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/program_binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698