Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2613893003: Gardening: improve debug output in standalone/io/socket_ipv6_test.dart. (Closed)

Created:
3 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: improve debug output in standalone/io/socket_ipv6_test.dart. This test is flaky on the bot - we need to better understand why it times out. (See issue #28266) R=kustermann@google.com BUG=http://dartbug.com/28266 Committed: https://github.com/dart-lang/sdk/commit/f3f70fea5fd895a2813de7722d30ed3fd250a468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M tests/standalone/io/socket_ipv6_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/standalone/io/test_utils.dart View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-05 14:20:00 UTC) #1
kustermann
lgtm
3 years, 11 months ago (2017-01-05 14:21:42 UTC) #2
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-05 14:32:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3f70fea5fd895a2813de7722d30ed3fd250a468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698