Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: ash/mus/bridge/wm_window_mus.cc

Issue 2613863005: Removes/promotes functions from WmWindowMus to WmWindowAura (Closed)
Patch Set: window_ part2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | ash/wm/window_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/bridge/wm_window_mus.cc
diff --git a/ash/mus/bridge/wm_window_mus.cc b/ash/mus/bridge/wm_window_mus.cc
index ce4c457d6c873a0592af6d6825a3447828390b87..6761fbfe224a1c5cb6647490c8407e0ba66ec5d5 100644
--- a/ash/mus/bridge/wm_window_mus.cc
+++ b/ash/mus/bridge/wm_window_mus.cc
@@ -74,52 +74,6 @@ WmShell* WmWindowMus::GetShell() const {
return WmShellMus::Get();
}
-int WmWindowMus::GetIntProperty(WmWindowProperty key) {
- if (key == WmWindowProperty::SHELF_ITEM_TYPE) {
- if (aura_window()->GetProperty(kShelfItemTypeKey) != TYPE_UNDEFINED)
- return aura_window()->GetProperty(kShelfItemTypeKey);
-
- // Mash provides a default shelf item type for non-ignored windows.
- return GetWindowState()->ignored_by_shelf() ? TYPE_UNDEFINED : TYPE_APP;
- }
-
- return WmWindowAura::GetIntProperty(key);
-}
-
-// TODO(sky): investigate if needed.
-bool WmWindowMus::MoveToEventRoot(const ui::Event& event) {
- views::View* target = static_cast<views::View*>(event.target());
- if (!target)
- return false;
- WmWindow* target_root =
- WmLookup::Get()->GetWindowForWidget(target->GetWidget())->GetRootWindow();
- if (!target_root || target_root == GetRootWindow())
- return false;
- WmWindow* window_container =
- target_root->GetChildByShellWindowId(GetParent()->GetShellWindowId());
- window_container->AddChild(this);
- return true;
-}
-
-// TODO(sky): investigate if needed.
-void WmWindowMus::SetBoundsInScreen(const gfx::Rect& bounds_in_screen,
- const display::Display& dst_display) {
- DCHECK(GetParent()); // Aura code assumed a parent, so this does too.
- if (static_cast<const WmWindowMus*>(GetParent())
- ->child_bounds_in_screen_behavior_ ==
- BoundsInScreenBehavior::USE_LOCAL_COORDINATES) {
- SetBounds(bounds_in_screen);
- return;
- }
- wm::SetBoundsInScreen(this, bounds_in_screen, dst_display);
-}
-
-// TODO(sky): remove this override.
-void WmWindowMus::SetPinned(bool trusted) {
- // http://crbug.com/622486.
- NOTIMPLEMENTED();
-}
-
void WmWindowMus::CloseWidget() {
views::Widget* widget = views::Widget::GetWidgetForNativeView(aura_window());
DCHECK(widget);
@@ -133,39 +87,6 @@ void WmWindowMus::CloseWidget() {
}
}
-// TODO(sky): investigate if needed.
-bool WmWindowMus::CanActivate() const {
- // TODO(sky): this isn't quite right. Should key off CanFocus(), which is not
- // replicated.
- // TODO(sky): fix const cast (most likely remove this override entirely).
- return WmWindowAura::CanActivate() &&
- views::Widget::GetWidgetForNativeView(
- const_cast<aura::Window*>(aura_window())) != nullptr;
-}
-
-void WmWindowMus::ShowResizeShadow(int component) {
- // TODO: http://crbug.com/640773.
- NOTIMPLEMENTED();
-}
-
-void WmWindowMus::HideResizeShadow() {
- // TODO: http://crbug.com/640773.
- NOTIMPLEMENTED();
-}
-
-void WmWindowMus::InstallResizeHandleWindowTargeter(
- ImmersiveFullscreenController* immersive_fullscreen_controller) {
- // TODO(sky): I believe once ImmersiveFullscreenController is ported this
- // won't be necessary in mash, but I need to verify that:
- // http://crbug.com/548435.
-}
-
-// TODO: nuke this once SetBoundsInScreen() is updated.
-void WmWindowMus::SetBoundsInScreenBehaviorForChildren(
- WmWindow::BoundsInScreenBehavior behavior) {
- child_bounds_in_screen_behavior_ = behavior;
-}
-
void WmWindowMus::AddLimitedPreTargetHandler(ui::EventHandler* handler) {
DCHECK(WmShellMus::Get()->window_tree_client()->WasCreatedByThisClient(
aura::WindowMus::Get(aura_window())));
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | ash/wm/window_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698