third_party/WebKit/Source/platform/graphics/ImageObserver.h - Issue 2613853002: Phase III Step 2: Call imageNotifyFinished() and image load event after SVG loading completes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/ImageObserver.h

Issue 2613853002: Phase III Step 2: Call imageNotifyFinished() and image load event after SVG loading completes (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/graphics/Image.h ('K') | « third_party/WebKit/Source/platform/graphics/Image.h ('k') | third_party/WebKit/Source/platform/loader/fetch/Resource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 30 matching lines...) Expand all Loading...
41 virtual ~ImageObserver();	41 virtual ~ImageObserver();

42	42

43 public:	43 public:

44 virtual void DecodedSizeChangedTo(const Image*, size_t new_size) = 0;	44 virtual void DecodedSizeChangedTo(const Image*, size_t new_size) = 0;

45	45

46 virtual bool ShouldPauseAnimation(const Image*) = 0;	46 virtual bool ShouldPauseAnimation(const Image*) = 0;

47 virtual void AnimationAdvanced(const Image*) = 0;	47 virtual void AnimationAdvanced(const Image*) = 0;

48	48

49 virtual void ChangedInRect(const Image*, const IntRect&) = 0;	49 virtual void ChangedInRect(const Image*, const IntRect&) = 0;

50	50

	51 // See the comment of Image::setData().

	52 virtual void LoadCompleted(const Image*) = 0;
	fs 2017/05/05 10:52:42 Since this has a strong tie to the "...LoadingAsyn Since this has a strong tie to the "...LoadingAsynchronously" "size state" (yes, that feels a bit weird TBH...) maybe this should rather be AsyncLoadCompleted? hiroshige 2017/05/08 17:22:07 Done. Show quoted text On 2017/05/05 10:52:42, fs wrote: > Since this has a strong tie to the "...LoadingAsynchronously" "size state" (yes, > that feels a bit weird TBH...) maybe this should rather be AsyncLoadCompleted? Done.
	53

51 DEFINE_INLINE_VIRTUAL_TRACE() {}	54 DEFINE_INLINE_VIRTUAL_TRACE() {}

52 };	55 };

53	56

54 } // namespace blink	57 } // namespace blink

55	58

56 #endif	59 #endif

OLD	NEW