Phase III Step 2: Call imageNotifyFinished() and image load event after SVG loading completes

third_party/WebKit/Source/core/svg/graphics/SVGImage.h

 /*
  * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
 
 #ifndef SVGImage_h
 #define SVGImage_h
 
 #include "core/CoreExport.h"
 #include "platform/graphics/Image.h"
 #include "platform/graphics/paint/PaintRecord.h"
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/wtf/Allocator.h"
+#include "platform/wtf/WeakPtr.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
 
 namespace blink {
 
 class Document;
 class Page;
 class PaintController;
 class LayoutReplaced;
 class SVGImageChromeClient;
 class SVGImageForContainer;
@@ skipping 130 matching lines @@
                                PaintFlags&,
                                const SkMatrix& local_matrix);
   bool ApplyShaderInternal(PaintFlags&,
                            const SkMatrix& local_matrix,
                            const KURL&);
 
   void StopAnimation();
   void ScheduleTimelineRewind();
   void FlushPendingTimelineRewind();
 
+  void LoadCompleted();
+
+  WTF::WeakPtr<SVGImage> AsWeakPtr() {
+    return weak_ptr_factory_.CreateWeakPtr();
+  }
+
+  class SVGImageLocalFrameClient;
+
   Persistent<SVGImageChromeClient> chrome_client_;
   Persistent<Page> page_;
   std::unique_ptr<PaintController> paint_controller_;
 
   // When an SVG image has no intrinsic size, the size depends on the default
   // object size, which in turn depends on the container. One SVGImage may
   // belong to multiple containers so the final image size can't be known in
   // SVGImage. SVGImageForContainer carries the final image size, also called
   // the "concrete object size". For more, see: SVGImageForContainer.h
   IntSize intrinsic_size_;
   bool has_pending_timeline_rewind_;
+
+  enum LoadState {
+    kDataChangedNotStarted,
+    kInDataChanged,
+    kWaitingForAsyncLoadCompletion,
+    kLoadCompletedSynchronously,

[fs, 2017/05/05 10:52:42]

We don't really need both kLoadCompletedSynchronously and
kLoadCompletedAsynchronously right? They represent the same state, and we have
no need to know how we got into that state. So kLoadCompleted ought to suffice?

[hiroshige, 2017/05/08 17:22:06]

Mostly. The state assertion at the bottom of SVGImage::DataChanged() is the only
place where two states are distinguished, but the state assertion is relatively
unimportant and unlikely. Merged them.

+    kLoadCompletedAsynchronously,
+  };
+
+  LoadState load_state_ = kDataChangedNotStarted;
+
+  WTF::WeakPtrFactory<SVGImage> weak_ptr_factory_;
 };
 
 DEFINE_IMAGE_TYPE_CASTS(SVGImage);
 
 class ImageObserverDisabler {
   STACK_ALLOCATED();
   WTF_MAKE_NONCOPYABLE(ImageObserverDisabler);
 
  public:
   ImageObserverDisabler(Image* image) : image_(image) {
     image_->SetImageObserverDisabled(true);
   }
 
   ~ImageObserverDisabler() { image_->SetImageObserverDisabled(false); }
 
  private:
   Image* image_;
 };
 
 }  // namespace blink
 
 #endif  // SVGImage_h