third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-crash.html - Issue 2613853002: Phase III Step 2: Call imageNotifyFinished() and image load event after SVG loading completes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-crash.html

Issue 2613853002: Phase III Step 2: Call imageNotifyFinished() and image load event after SVG loading completes (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/as-image/data-font-in-css-invalid-data-url-crash.html » ('j') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	fs 2017/05/05 10:52:42 uNit: <html> and <head> (and corresponding end tag uNit: <html> and <head> (and corresponding end tags) don't add any value to the test, so they can be removed. hiroshige 2017/05/08 17:22:06 Done. Show quoted text On 2017/05/05 10:52:42, fs wrote: > uNit: <html> and <head> (and corresponding end tags) don't add any value to the > test, so they can be removed. Done.
	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script>

	7 var t1 = async_test("Loading of SVG with a valid font completes " +
	fs 2017/05/05 10:52:42 Personally I think I would've written these tests Personally I think I would've written these tests (this one and following ones) as a single test with multiple steps (to avoid having one test essentially depend on the other.) But that may be somewhat subjective, so If you prefer this way and want to keep it like this, it's fine with me. (Thought I'd just mention the alternative.) hiroshige 2017/05/08 17:22:06 Done. Show quoted text On 2017/05/05 10:52:42, fs wrote: > Personally I think I would've written these tests (this one and following ones) > as a single test with multiple steps (to avoid having one test essentially > depend on the other.) But that may be somewhat subjective, so If you prefer this > way and want to keep it like this, it's fine with me. (Thought I'd just mention > the alternative.) Done.
	8 "before <img> load event and drawImage() doesn't crash.");

	9 var t2 = async_test("Loading of SVG with a valid font completes " +

	10 "before <body> load event and drawImage() doesn't crash.");

	11

	12 var imgOnLoadCalled = false;

	13

	14 function doTest() {

	15 var svg = document.getElementById('img');

	16 var canvas = document.createElement("canvas");

	17 var ctx = canvas.getContext("2d");

	18 ctx.drawImage(svg, 0, 0);

	19 }

	20

	21 var imgOnLoad = t1.step_func_done(function() {

	22 imgOnLoadCalled = true;

	23 doTest();

	24 });

	25

	26 var bodyOnLoad = t2.step_func_done(function() {

	27 assert_true(imgOnLoadCalled,

	28 "<img> load event must be fired before <body> load event");

	29 doTest();

	30 });

	31 </script>

	32 </head>

	33 <body onload="bodyOnLoad()">

	34 <img src="resources/data-font-in-css.svg" id="img" onload="imgOnLoad()">

	35 </body>

	36 </html>

OLD	NEW