Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2613833005: Use entities in the TypeMask interface. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -40 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +3 lines, -3 lines 2 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 7 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-06 15:17:50 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2613833005/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right): https://codereview.chromium.org/2613833005/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart#newcode14 pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:14: import '../elements/resolution_types.dart' show DartType, InterfaceType; I assume this ...
3 years, 11 months ago (2017-01-06 20:48:36 UTC) #3
Johnni Winther
https://codereview.chromium.org/2613833005/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right): https://codereview.chromium.org/2613833005/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart#newcode14 pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:14: import '../elements/resolution_types.dart' show DartType, InterfaceType; On 2017/01/06 20:48:36, Siggi ...
3 years, 11 months ago (2017-01-09 09:05:04 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-09 09:46:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d1ef805c383e61c99d14047069291cd65fa7d8b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698