Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/chrome_content_browser_client_unittest.cc

Issue 2613833004: Split BrowsingDataRemover into an abstract interface and implementation. (Closed)
Patch Set: Removed unnecessary instantiations. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client_unittest.cc
diff --git a/chrome/browser/chrome_content_browser_client_unittest.cc b/chrome/browser/chrome_content_browser_client_unittest.cc
index 3647cdada7dfb2a8f610d63b4f56de1b512f68a2..8461f7f0ec129b75a64f2679a6934aa9884f7d45 100644
--- a/chrome/browser/chrome_content_browser_client_unittest.cc
+++ b/chrome/browser/chrome_content_browser_client_unittest.cc
@@ -19,8 +19,8 @@
#include "build/build_config.h"
#include "chrome/browser/browsing_data/browsing_data_filter_builder.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
-#include "chrome/browser/browsing_data/browsing_data_remover.h"
#include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
+#include "chrome/browser/browsing_data/browsing_data_remover_impl.h"
#include "chrome/browser/browsing_data/origin_filter_builder.h"
#include "chrome/browser/browsing_data/registrable_domain_filter_builder.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
@@ -345,10 +345,14 @@ TEST_F(InstantNTPURLRewriteTest, UberURLHandler_InstantExtendedNewTabPage) {
namespace {
// A BrowsingDataRemover that only records calls.
-class MockBrowsingDataRemover : public BrowsingDataRemover {
+// TODO(msramek): Once BrowsingDataRemoverImpl moves to content/ (non-public),
+// it will not be possible to inherit from it here. However, at that time
+// this functionality will become redundant, as it will no longer be necessary
+// to call to chrome/ to perform deletion. Remove it then.
+class MockBrowsingDataRemover : public BrowsingDataRemoverImpl {
public:
explicit MockBrowsingDataRemover(content::BrowserContext* context)
- : BrowsingDataRemover(context) {}
+ : BrowsingDataRemoverImpl(context) {}
~MockBrowsingDataRemover() override {
DCHECK(!expected_calls_.size())
« no previous file with comments | « chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698