LayoutTests/fast/multicol/balance-short-trailing-empty-block.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/balance-short-trailing-empty-block.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ... aaand, better expect the test to pass, now that it's actually fixed, hm? :-P Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Tests that a block a column boundary is recorded properly for b alancing");

	5 if (window.internals)

	6 internals.settings.setRegionBasedColumnsEnabled(true);

	7 </script>

	8 <p>Both words below should be in the the right column.</p>
	Julien - ping for review 2014/05/09 18:23:53 Nit: Add a <div id="console"> after this so that t Nit: Add a <div id="console"> after this so that the output of the test falls nicely after both your description and condition for passing. mstensho (USE GERRIT) 2014/05/10 16:28:22 Done. Had to move description() down to make it wo Show quoted text On 2014/05/09 18:23:53, Julien Chaffraix - PST wrote: > Nit: Add a <div id="console"> after this so that the output of the test falls > nicely after both your description and condition for passing. Done. Had to move description() down to make it work.
	9 <div id="mc" style="-webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-c olumn-rule:1px solid; column-rule:1px solid; background:olive;">

	10 <div style="height:120px;"></div>

	11 <div style="line-height:80px;">right<br>column</div>

	12 <div style="height:30px;"></div>

	13 </div>

	14 <script>

	15 shouldBe("mc.offsetHeight", "190");

	16 </script>

OLD	NEW