LayoutTests/fast/multicol/balance-unbreakable.html - Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/balance-unbreakable.html

Issue 261383004: [New Multicolumn] Improve balancing for border/padding and empty block content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address code review issues raised together with lgtm Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/balance-trailing-border2-expected.txt ('k') | LayoutTests/fast/multicol/balance-unbreakable-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 if (window.internals)

	5 internals.settings.setRegionBasedColumnsEnabled(true);

	6 </script>

	7 <p>There should be a <em>square</em> with some stuff inside below.</p>

	8 <div id="console"></div>

	9 <div id="mc" style="-webkit-columns:3; columns:3; width:7em; float:left; orphans :1; widows:1; background:olive;">

	10 <div style="line-height:4em;">line</div>

	11 <div style="line-height:8em;">line</div>

	12 <img alt="x" style="display:block; height:2em;">

	13 <div style="line-height:4em;">line</div>

	14 <div style="line-height:10em;">line</div>

	15 <div style="line-height:2em;">line</div>

	16 <div style="line-height:6em;">line</div>

	17 </div>

	18 <div style="float:left; width:7em; height:14em; background:olive;"></div>

	19 <script>

	20 description("Tests that an image at a column boundary is recorded properly f or balancing");

	21 shouldBe("mc.offsetHeight", "224");

	22 </script>

OLD	NEW