[win] Enable ModuleDatabase behind a flag.

chrome/browser/conflicts/module_event_sink_impl_win.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONFLICTS_MODULE_EVENT_SINK_IMPL_WIN_H_
 #define CHROME_BROWSER_CONFLICTS_MODULE_EVENT_SINK_IMPL_WIN_H_
 
 #include <stdint.h>
 
+#include "base/callback.h"

[grt (UTC plus 2), 2017/01/06 09:44:58]

will callback_forward.h work here?

[chrisha, 2017/01/10 21:01:46]

Indeed it will!

 #include "base/process/process_handle.h"
 #include "chrome/common/conflicts/module_event_sink_win.mojom.h"
 #include "content/public/common/process_type.h"
 
 class ModuleDatabase;
 
 // Implementation of the mojom::ModuleEventSink interface. This is the endpoint
 // in the browser process. This redirects calls to the singleton ModuleDatabase
 // object.
 class ModuleEventSinkImpl : public mojom::ModuleEventSink {
  public:
+  // Callback for retrieving the handle associated with a process. This is used
+  // by "Create" to get a handle to the remote process.
+  using GetProcessHandleCallback = base::Callback<base::ProcessHandle()>;
+
   // Creates a service endpoint that forwards notifications from the remote
   // |process| of the provided |process_type| to the provided |module_database|.
   // The |module_database| must outlive this object.
   ModuleEventSinkImpl(base::ProcessHandle process,
                       content::ProcessType process_type,
                       ModuleDatabase* module_database);
   ~ModuleEventSinkImpl() override;
 
   // Factory function for use with service_manager::InterfaceRegistry. This
   // creates a concrete implementation of mojom::ModuleDatabase interface in the
   // current process, for the remote process represented by the provided
   // |request|. This should only be called on the UI thread.
-  static void Create(base::ProcessHandle process,
+  static void Create(const GetProcessHandleCallback& get_process_handle,

[grt (UTC plus 2), 2017/01/06 09:44:58]

should this be passed by value as per
https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md#Memo...

[chrisha, 2017/01/10 21:01:46]

Yup... old habits die hard.

                      content::ProcessType process_type,
                      ModuleDatabase* module_database,
                      mojom::ModuleEventSinkRequest request);
 
   // mojom::ModuleEventSink implementation:
   void OnModuleEvent(mojom::ModuleEventType event_type,
                      uint64_t load_address) override;
 
   bool in_error() const { return in_error_; }
 
+  // Gets the process creation time associated with the given process.
+  static bool GetProcessCreationTime(base::ProcessHandle process,
+                                     uint64_t* creation_time);
+
  private:
   friend class ModuleEventSinkImplTest;
 
   // OnModuleEvent disptaches to these two functions depending on the event
   // type.
   void OnModuleLoad(uint64_t load_address);
   void OnModuleUnload(uint64_t load_address);
 
   // A handle to the process on the other side of the pipe.
   base::ProcessHandle process_;
@@ skipping 11 matching lines @@
   uint64_t creation_time_;
 
   // Indicates whether or not this connection is in an error mode. If true then
   // all communication from the remote client is silently dropped.
   bool in_error_;
 
   DISALLOW_COPY_AND_ASSIGN(ModuleEventSinkImpl);
 };
 
 #endif  // CHROME_BROWSER_CONFLICTS_MODULE_EVENT_SINK_IMPL_WIN_H_