content/browser/android/child_process_launcher_android.h - Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/child_process_launcher_android.h

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)

Patch Set: Addressed jam@'s comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/child_process_launcher_android.h

diff --git a/content/browser/android/child_process_launcher_android.h b/content/browser/android/child_process_launcher_android.h

index b99fbd72f6eefa60b79b25aece4ec1f67df79ab5..78f088a6c5a743fb4e8a83e4aa8dd6e89c264bab 100644

--- a/content/browser/android/child_process_launcher_android.h

+++ b/content/browser/android/child_process_launcher_android.h

@@ -29,7 +29,6 @@ void StartChildProcess(

const base::CommandLine::StringVector& argv,

int child_process_id,

const std::unique_ptr<FileDescriptorInfo> files_to_register,

- const std::map<int, base::MemoryMappedFile::Region>& regions,

const StartChildProcessCallback& callback);

// Stops a child process based on the handle returned form