Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)
Patch Set: Addressed jam@'s comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 7a9c62a1b0c99f04c8ad1b2ad5182bfbd06c2f9f..9d51c8fcee5236abda1698a269b9b03dbb6caa27 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -474,18 +474,16 @@ content::TracingDelegate* AwContentBrowserClient::GetTracingDelegate() {
void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
const base::CommandLine& command_line,
int child_process_id,
- content::FileDescriptorInfo* mappings,
- std::map<int, base::MemoryMappedFile::Region>* regions) {
- int fd = ui::GetMainAndroidPackFd(
- &(*regions)[kAndroidWebViewMainPakDescriptor]);
- mappings->Share(kAndroidWebViewMainPakDescriptor, fd);
-
- fd = ui::GetCommonResourcesPackFd(
- &(*regions)[kAndroidWebView100PercentPakDescriptor]);
- mappings->Share(kAndroidWebView100PercentPakDescriptor, fd);
-
- fd = ui::GetLocalePackFd(&(*regions)[kAndroidWebViewLocalePakDescriptor]);
- mappings->Share(kAndroidWebViewLocalePakDescriptor, fd);
+ content::FileDescriptorInfo* mappings) {
+ base::MemoryMappedFile::Region region;
+ int fd = ui::GetMainAndroidPackFd(&region);
+ mappings->ShareWithRegion(kAndroidWebViewMainPakDescriptor, fd, region);
+
+ fd = ui::GetCommonResourcesPackFd(&region);
+ mappings->ShareWithRegion(kAndroidWebView100PercentPakDescriptor, fd, region);
+
+ fd = ui::GetLocalePackFd(&region);
+ mappings->ShareWithRegion(kAndroidWebViewLocalePakDescriptor, fd, region);
base::ScopedFD crash_signal_file =
breakpad::CrashMicroDumpManager::GetInstance()->CreateCrashInfoChannel(
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698