Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: content/browser/child_process_launcher.cc

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index e93bb08efd4846340e6c467b0c349efee237bdb2..2ea18bc29d4127092d1414231ce81d20c345f270 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -176,11 +176,7 @@ void LaunchOnLauncherThread(
#if defined(OS_POSIX) && !defined(OS_MACOSX)
std::map<int, base::MemoryMappedFile::Region> regions;
boliu 2017/01/05 07:02:08 seems incomplete this is still here and the region
Jay Civelli 2017/01/05 17:12:18 You are right. This is part of a bigger CL I am br
GetContentClient()->browser()->GetAdditionalMappedFilesForChildProcess(
- *cmd_line, child_process_id, files_to_register.get()
-#if defined(OS_ANDROID)
- , &regions
-#endif
- );
+ *cmd_line, child_process_id, files_to_register.get());
#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
bool snapshot_loaded = false;
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698