Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Side by Side Diff: content/public/browser/content_browser_client.h

Issue 2613803003: Simplifying ContentBrowserClient::GetAdditionalMappedFiles...() (Closed)
Patch Set: Addressed jam@'s comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 6 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 // If this function returns nullptr, a default platform implementation 757 // If this function returns nullptr, a default platform implementation
758 // will be used. 758 // will be used.
759 virtual media::ScopedAudioManagerPtr CreateAudioManager( 759 virtual media::ScopedAudioManagerPtr CreateAudioManager(
760 media::AudioLogFactory* audio_log_factory); 760 media::AudioLogFactory* audio_log_factory);
761 // Creates and returns a factory used for creating CDM instances for playing 761 // Creates and returns a factory used for creating CDM instances for playing
762 // protected content. 762 // protected content.
763 virtual std::unique_ptr<media::CdmFactory> CreateCdmFactory(); 763 virtual std::unique_ptr<media::CdmFactory> CreateCdmFactory();
764 764
765 // Populates |mappings| with all files that need to be mapped before launching 765 // Populates |mappings| with all files that need to be mapped before launching
766 // a child process. 766 // a child process.
767 #if defined(OS_ANDROID) 767 #if defined(OS_POSIX) && !defined(OS_MACOSX)
768 virtual void GetAdditionalMappedFilesForChildProcess(
769 const base::CommandLine& command_line,
770 int child_process_id,
771 content::FileDescriptorInfo* mappings,
772 std::map<int, base::MemoryMappedFile::Region>* regions) {}
773 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
774 virtual void GetAdditionalMappedFilesForChildProcess( 768 virtual void GetAdditionalMappedFilesForChildProcess(
775 const base::CommandLine& command_line, 769 const base::CommandLine& command_line,
776 int child_process_id, 770 int child_process_id,
777 content::FileDescriptorInfo* mappings) {} 771 content::FileDescriptorInfo* mappings) {}
778 #endif // defined(OS_ANDROID) 772 #endif // defined(OS_POSIX) && !defined(OS_MACOSX)
779 773
780 #if defined(OS_WIN) 774 #if defined(OS_WIN)
781 // This is called on the PROCESS_LAUNCHER thread before the renderer process 775 // This is called on the PROCESS_LAUNCHER thread before the renderer process
782 // is launched. It gives the embedder a chance to add loosen the sandbox 776 // is launched. It gives the embedder a chance to add loosen the sandbox
783 // policy. 777 // policy.
784 virtual bool PreSpawnRenderer(sandbox::TargetPolicy* policy); 778 virtual bool PreSpawnRenderer(sandbox::TargetPolicy* policy);
785 779
786 // Returns the AppContainer SID for the specified sandboxed process type, or 780 // Returns the AppContainer SID for the specified sandboxed process type, or
787 // empty string if this sandboxed process type does not support living inside 781 // empty string if this sandboxed process type does not support living inside
788 // an AppContainer. 782 // an AppContainer.
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 virtual bool ShouldRedirectDOMStorageTaskRunner(); 814 virtual bool ShouldRedirectDOMStorageTaskRunner();
821 815
822 // If this returns true, all BrowserThreads (but UI/IO) that support it on 816 // If this returns true, all BrowserThreads (but UI/IO) that support it on
823 // this platform will experimentally be redirected to TaskScheduler. 817 // this platform will experimentally be redirected to TaskScheduler.
824 virtual bool RedirectNonUINonIOBrowserThreadsToTaskScheduler(); 818 virtual bool RedirectNonUINonIOBrowserThreadsToTaskScheduler();
825 }; 819 };
826 820
827 } // namespace content 821 } // namespace content
828 822
829 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_ 823 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « content/browser/file_descriptor_info_impl.cc ('k') | content/public/browser/file_descriptor_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698