Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2613793003: [Command buffer] It is unnecessary to set clear_state_dirty when image content changed (Closed)
Patch Set: remove Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 8fe53bb2e6e7224ab189f047ca8c50404a1f3378..0b826e04aba68ffed9f5d97434c07b843ce02ccd 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -13470,10 +13470,6 @@ error::Error GLES2DecoderImpl::DoCompressedTexImage(
return error::kNoError;
}
- if (texture->IsAttachedToFramebuffer()) {
- framebuffer_state_.clear_state_dirty = true;
- }
-
std::unique_ptr<int8_t[]> zero;
if (!state_.bound_pixel_unpack_buffer && !data) {
zero.reset(new int8_t[image_size]);
@@ -14077,10 +14073,6 @@ void GLES2DecoderImpl::DoCopyTexImage2D(
ScopedResolvedFramebufferBinder binder(this, false, true);
gfx::Size size = GetBoundReadFramebufferSize();
- if (texture->IsAttachedToFramebuffer()) {
- framebuffer_state_.clear_state_dirty = true;
- }
-
bool requires_luma_blit =
CopyTexImageResourceManager::CopyTexImageRequiresBlit(feature_info_.get(),
format);
@@ -16909,9 +16901,6 @@ void GLES2DecoderImpl::TexStorageImpl(GLenum target,
return;
}
Texture* texture = texture_ref->texture();
- if (texture->IsAttachedToFramebuffer()) {
- framebuffer_state_.clear_state_dirty = true;
- }
if (texture->IsImmutable()) {
LOCAL_SET_GL_ERROR(
GL_INVALID_OPERATION, function_name, "texture is immutable");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698