Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

Issue 2613783002: DevTools: Fix network request details on timeline flamechart (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @implements {UI.FlameChartDataProvider} 6 * @implements {UI.FlameChartDataProvider}
7 * @unrestricted 7 * @unrestricted
8 */ 8 */
9 Timeline.TimelineFlameChartNetworkDataProvider = class { 9 Timeline.TimelineFlameChartNetworkDataProvider = class {
10 /** 10 /**
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 * @param {number} startTime 85 * @param {number} startTime
86 * @param {number} endTime 86 * @param {number} endTime
87 */ 87 */
88 setWindowTimes(startTime, endTime) { 88 setWindowTimes(startTime, endTime) {
89 this._startTime = startTime; 89 this._startTime = startTime;
90 this._endTime = endTime; 90 this._endTime = endTime;
91 this._updateTimelineData(); 91 this._updateTimelineData();
92 } 92 }
93 93
94 /** 94 /**
95 * @param {number} index
96 * @return {?Timeline.TimelineSelection}
97 */
98 createSelection(index) {
99 if (index === -1)
100 return null;
101 var request = this._requests[index];
102 this._lastSelection =
103 new Timeline.TimelineFlameChartView.Selection(Timeline.TimelineSelection .fromNetworkRequest(request), index);
104 return this._lastSelection.timelineSelection;
105 }
106
107 /**
95 * @param {?Timeline.TimelineSelection} selection 108 * @param {?Timeline.TimelineSelection} selection
96 * @return {number} 109 * @return {number}
97 */ 110 */
98 entryIndexForSelection(selection) { 111 entryIndexForSelection(selection) {
99 if (!selection) 112 if (!selection)
100 return -1; 113 return -1;
101 114
102 if (this._lastSelection && this._lastSelection.timelineSelection.object() == = selection.object()) 115 if (this._lastSelection && this._lastSelection.timelineSelection.object() == = selection.object())
103 return this._lastSelection.entryIndex; 116 return this._lastSelection.entryIndex;
104 117
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 381
369 /** 382 /**
370 * @override 383 * @override
371 * @param {number} entryIndex 384 * @param {number} entryIndex
372 * @return {boolean} 385 * @return {boolean}
373 */ 386 */
374 canJumpToEntry(entryIndex) { 387 canJumpToEntry(entryIndex) {
375 return false; 388 return false;
376 } 389 }
377 }; 390 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698