Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Issue 2613753002: W3C import: Update manifest-updating step after upstream changes. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
index 806ca41ed9770547de2b96b9eaae11e299f28c44..46427f553359c5846fa0ee3d98bae3b1ad96acb4 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
@@ -89,3 +89,40 @@ class DepsUpdaterTest(unittest.TestCase):
'TBR=qyearsley@chromium.org\n'
'NOEXPORT=true'))
self.assertEqual(host.executive.calls, [['git', 'log', '-1', '--format=%B']])
+
+ def test_generate_manifest_command_not_found(self):
+ # If we're updating csswg-test, then the manifest file won't be found.
+ host = MockHost()
+ host.filesystem.files = {}
+ updater = DepsUpdater(host)
+ updater._generate_manifest(
+ '/mock-checkout/third_party/WebKit/css',
+ '/mock-checkout/third_party/WebKit/LayoutTests/imported/csswg-test')
+ self.assertEqual(host.executive.calls, [])
+
+ def test_generate_manifest_successful_run(self):
+ # This test doesn't test any aspect of the real manifest script, it just
+ # asserts that DepsUpdater._generate_manifest would invoke the script.
+ host = MockHost()
+ host.filesystem.files = {
+ '/mock-checkout/third_party/WebKit/wpt/manifest': 'dummy content'
+ }
+ updater = DepsUpdater(host)
+ updater._generate_manifest(
+ '/mock-checkout/third_party/WebKit/wpt',
+ '/mock-checkout/third_party/WebKit/LayoutTests/imported/wpt')
+ self.assertEqual(
+ host.executive.calls,
+ [
+ [
+ '/mock-checkout/third_party/WebKit/wpt/manifest',
+ '--work',
+ '--tests-root',
+ '/mock-checkout/third_party/WebKit/LayoutTests/imported/wpt'
+ ],
+ [
+ 'git',
+ 'add',
+ '/mock-checkout/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json'
+ ]
+ ])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698