Clip related property and border radius are now recorded for UMA

third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 1060 matching lines @@
     forceFullCompositingUpdate();
 
     ASSERT_FALSE(frameView->mainThreadScrollingReasons() & reason);
 
     // Add target attribute would again lead to scroll on main thread
     container->setAttribute("class", target.c_str(), ASSERT_NO_EXCEPTION);
     forceFullCompositingUpdate();
 
     ASSERT_TRUE(frameView->mainThreadScrollingReasons() & reason);
 
-    webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(true);
-    forceFullCompositingUpdate();
-
-    ASSERT_FALSE(frameView->mainThreadScrollingReasons());
+    if (reason & (MainThreadScrollingReason::kHasOpacity |
+                  MainThreadScrollingReason::kHasTransform |
+                  MainThreadScrollingReason::kBackgroundNotOpaqueInRect)) {

[bokan, 2017/01/05 14:05:48]

You should also check that there aren't any of the non-LCD-text reasons
otherwise the assert below will fail. You currently don't test any layers that
have more than one reason so that wont happen, but I think you should add a test
that uses two reasons, e.g. "border-radius and opacity" and ensure that the
appropriate reasons are set.

[yigu, 2017/01/05 14:46:51]

Done.

+      webViewImpl()->settings()->setPreferCompositingToLCDTextEnabled(true);
+      forceFullCompositingUpdate();
+      ASSERT_FALSE(frameView->mainThreadScrollingReasons());
+    }
   }
 };
 
 TEST_F(StyleRelatedMainThreadScrollingReasonTest, TransparentTest) {
   testStyle("transparent", MainThreadScrollingReason::kHasOpacity);
 }
 
 TEST_F(StyleRelatedMainThreadScrollingReasonTest, TransformTest) {
   testStyle("transform", MainThreadScrollingReason::kHasTransform);
 }
 
 TEST_F(StyleRelatedMainThreadScrollingReasonTest, BackgroundNotOpaqueTest) {
   testStyle("background-not-opaque",
             MainThreadScrollingReason::kBackgroundNotOpaqueInRect);
 }
 
+TEST_F(StyleRelatedMainThreadScrollingReasonTest, BorderRadiusTest) {
+  testStyle("border-radius", MainThreadScrollingReason::kHasBorderRadius);
+}
+
+TEST_F(StyleRelatedMainThreadScrollingReasonTest, ClipTest) {
+  testStyle("clip", MainThreadScrollingReason::kHasClipRelatedProperty);
+}
+
+TEST_F(StyleRelatedMainThreadScrollingReasonTest, ClipPathTest) {
+  testStyle("clip-path", MainThreadScrollingReason::kHasClipRelatedProperty);
+}
+
 }  // namespace blink