Make ToolbarActionsModel own ComponentToolbarActionsFactory

chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.h"
 
-#include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "extensions/common/feature_switch.h"
 
 // static
 const char MockComponentToolbarActionsFactory::kActionIdForTesting[] =
     "mock_action";
 
 MockComponentToolbarActionsFactory::MockComponentToolbarActionsFactory(
-    Browser* browser)
-    : migrated_feature_enabled_(false) {
-  ComponentToolbarActionsFactory::SetTestingFactory(this);
-}
+    Profile* profile,
+    ToolbarActionsModel* actions_model)
+    : ComponentToolbarActionsFactory(profile, actions_model),
+      migrated_feature_enabled_(false) {}
 
-MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() {
-  ComponentToolbarActionsFactory::SetTestingFactory(nullptr);
-}
+MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() {}
 
 std::set<std::string>
-MockComponentToolbarActionsFactory::GetInitialComponentIds(Profile* profile) {
+MockComponentToolbarActionsFactory::GetInitialComponentIds() {
   std::set<std::string> ids;
   // kActionIdForTesting is installed by default if we are not testing
   // a migration scenario.
   if (extensions::FeatureSwitch::extension_action_redesign()->IsEnabled() &&
       migrated_extension_id_.empty()) {
     ids.insert(kActionIdForTesting);
   }
   return ids;
 }
 
 std::unique_ptr<ToolbarActionViewController>
 MockComponentToolbarActionsFactory::GetComponentToolbarActionForId(
     const std::string& id,
     Browser* browser,
     ToolbarActionsBar* bar) {
   DCHECK_EQ(kActionIdForTesting, id);
   return std::unique_ptr<ToolbarActionViewController>(
       new TestToolbarActionViewController(
           MockComponentToolbarActionsFactory::kActionIdForTesting));
 }
 
-void MockComponentToolbarActionsFactory::RegisterComponentMigrations(
-    extensions::ComponentMigrationHelper* helper) const {
+void MockComponentToolbarActionsFactory::RegisterComponentMigrations() {
   if (!migrated_extension_id_.empty()) {

[msw, 2017/01/10 23:23:59]

optional nit: curlies not needed

[takumif, 2017/02/17 03:22:51]

Removed migration-related code.

-    helper->Register(kActionIdForTesting, migrated_extension_id_);
+    migration_helper_.Register(kActionIdForTesting, migrated_extension_id_);
   }
 }
 
-void MockComponentToolbarActionsFactory::HandleComponentMigrations(
-    extensions::ComponentMigrationHelper* helper,
-    Profile* profile) const {
+void MockComponentToolbarActionsFactory::HandleComponentMigrations() {
   if (migrated_extension_id_.empty())
     return;
 
   if (migrated_feature_enabled_) {

[msw, 2017/01/10 23:23:59]

optional nit: curlies not needed

[takumif, 2017/02/17 03:22:51]

Removed migration-related code.

-    helper->OnFeatureEnabled(kActionIdForTesting);
+    migration_helper_.OnFeatureEnabled(kActionIdForTesting);
   } else {
-    helper->OnFeatureDisabled(kActionIdForTesting);
+    migration_helper_.OnFeatureDisabled(kActionIdForTesting);
   }
 }