Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2613703002: [inspector] Make LayoutTest inspector/network/network-datareceived less slow

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 5 months ago
Reviewers:
allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[inspector] Make LayoutTest inspector/network/network-datareceived less slow The size of payload is decreased from 50KB to 5KB. On Linux Debug build, the time spent (s) vs. payload size (byte) is: payload size | time spent 5 | 3.05 500 | 3.46 5000 | 3.97 50000 | 27.58 500000 | TIMEOUT BUG=451577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (5 generated)
wychen
PTAL
3 years, 11 months ago (2017-01-04 12:50:29 UTC) #4
dgozman
Deferring to allada@
3 years, 11 months ago (2017-01-04 18:13:01 UTC) #6
allada
3 years, 11 months ago (2017-01-04 18:33:24 UTC) #7
Hmmmm, I don't see any issue with this change, but I am going to challenge why
it's slow. 50k should be plenty fast and PHP should be able to handle 50kb of
data with little impact.

I am curious if there is a layout regression with printing lots of "*"
characters.

Can you give me the timing info for this test with a checkout from somewhere
around last year?

Powered by Google App Engine
This is Rietveld 408576698