components/sync/protocol/proto_visitors.h - Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/protocol/proto_visitors.h

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)

Patch Set: Address latest skau comments, rebase and make it work with recent sync changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/protocol/proto_visitors.h

diff --git a/components/sync/protocol/proto_visitors.h b/components/sync/protocol/proto_visitors.h

index 350b715e234dde3f9569e53cbd01dc421ab69204..cf815a301fd272f7d8873be75ee0d6e6d8cf78c4 100644

--- a/components/sync/protocol/proto_visitors.h

+++ b/components/sync/protocol/proto_visitors.h

@@ -205,8 +205,7 @@ VISIT_PROTO_FIELDS(const sync_pb::ArcPackageSpecifics& proto) {

VISIT_PROTO_FIELDS(const sync_pb::PrinterPPDReference& proto) {

VISIT(user_supplied_ppd_url);

- VISIT(effective_manufacturer);

- VISIT(effective_model);

+ VISIT(effective_make_and_model);

}

VISIT_PROTO_FIELDS(const sync_pb::ReadingListSpecifics& proto) {