Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: components/sync/protocol/printer_specifics.proto

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)
Patch Set: Address latest skau comments, rebase and make it work with recent sync changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/printing/printer_translator_unittest.cc ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/printer_specifics.proto
diff --git a/components/sync/protocol/printer_specifics.proto b/components/sync/protocol/printer_specifics.proto
index e0881b71dd56b355ff42511fa9a22ba9d084f94e..e90813334db43c864244d3785dcb012bb51efa73 100644
--- a/components/sync/protocol/printer_specifics.proto
+++ b/components/sync/protocol/printer_specifics.proto
@@ -18,9 +18,12 @@ message PrinterPPDReference {
// Url for user provided file. Overrides other fields.
optional string user_supplied_ppd_url = 1;
- // Make and model to reference into PPD Server.
- optional string effective_manufacturer = 2;
- optional string effective_model = 3;
+ // Retired fields
+ reserved 2 to 4;
skau 2017/01/27 19:16:10 You can use 4. We never committed a CL that reser
Carlson 2017/01/27 22:56:22 Indeed, that was used in a previous revision of *t
+
+ // String identifying the type of printer, used to look up a ppd to drive the
+ // printer.
+ optional string effective_make_and_model = 5;
}
message PrinterSpecifics {
« no previous file with comments | « chromeos/printing/printer_translator_unittest.cc ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698