components/sync/protocol/printer_specifics.proto - Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/protocol/printer_specifics.proto

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)

Patch Set: Plumb through rest of changes, address skau comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/protocol/printer_specifics.proto

diff --git a/components/sync/protocol/printer_specifics.proto b/components/sync/protocol/printer_specifics.proto

index a42a815df745f25fbd7898e1e3147096e36e088d..56638253ec6304af434c8ca70b2b0153c7cda6c8 100644

--- a/components/sync/protocol/printer_specifics.proto

+++ b/components/sync/protocol/printer_specifics.proto

@@ -18,9 +18,11 @@ message PrinterPPDReference {

// Url for user provided file. Overrides other fields.

optional string user_supplied_ppd_url = 1;

- // Make and model to reference into PPD Server.

- optional string effective_manufacturer = 2;

- optional string effective_model = 3;

+ // FIELD 2 RETIRED

skau 2017/01/27 01:37:02 If it compiles (it was supposed to be fixed) can w

Carlson 2017/01/27 18:48:43 Done.

+ // FIELD 3 RETIRED

+ // Key used to find a ppd for this printer from the ppd server.

+ optional string ppd_server_key = 4;

}

message PrinterSpecifics {