chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html - Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)

Patch Set: Plumb through rest of changes, address skau comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printing/ppd_provider_factory.cc ('k') | chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc » ('j') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

index f08c5e7b3e3f81f5233fe074b8c7bc919eb50fa1..509bf191619cb85ba09df8224038e3c27bc06f42 100644

--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

@@ -58,9 +58,9 @@

<paper-input-container no-label-float>

<input is="iron-input" type="search" on-tap="onTap_"

on-search="onInputValueChanged_" on-change="onChange_" incremental>

- <paper-icon-button suffix id="searchIcon" icon="cr:search" hidden>

+ <paper-icon-button suffix id="searchIcon" icon="cr:search" on-tap="onTap_" hidden>

skau 2017/01/27 01:38:09 Can you put this file in a separate CL? These cha

Carlson 2017/01/27 18:48:43 Had already done this, just hadn't synced, sorry.

</paper-icon-button>

- <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down">

+ <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down" on-tap="onTap_">

</paper-icon-button>

</paper-input-container>

<iron-dropdown horizontal-align="left" vertical-align="top"