components/sync/protocol/printer_specifics.proto - Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/protocol/printer_specifics.proto

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)

Patch Set: Address michealpg@ comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/protocol/printer_specifics.proto

diff --git a/components/sync/protocol/printer_specifics.proto b/components/sync/protocol/printer_specifics.proto

index e0881b71dd56b355ff42511fa9a22ba9d084f94e..16d4f96c582bf26e80957e3f034789b2c7cb3def 100644

--- a/components/sync/protocol/printer_specifics.proto

+++ b/components/sync/protocol/printer_specifics.proto

@@ -18,9 +18,13 @@ message PrinterPPDReference {

// Url for user provided file. Overrides other fields.

optional string user_supplied_ppd_url = 1;

- // Make and model to reference into PPD Server.

- optional string effective_manufacturer = 2;

- optional string effective_model = 3;

+ // Retired fields

+ optional string effective_manufacturer = 2 [deprecated = true];

+ optional string effective_model = 3 [deprecated = true];

+ // String identifying the type of printer, used to look up a ppd to drive the

+ // printer.

+ optional string effective_make_and_model = 4;

}

message PrinterSpecifics {

« no previous file with comments | « chromeos/printing/printing_constants.h ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »