Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chromeos/printing/printer_translator_unittest.cc

Issue 2613683004: Completely rewrite the PpdProvider/PpdCache to use the SCS backend. Along the way, clean it up a l… (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/printing/printer_translator_unittest.cc
diff --git a/chromeos/printing/printer_translator_unittest.cc b/chromeos/printing/printer_translator_unittest.cc
index 4b5556296af7322c084f47676579de05e6324cf4..d8af0f131b8e26837a2d17190acaf4e974517faa 100644
--- a/chromeos/printing/printer_translator_unittest.cc
+++ b/chromeos/printing/printer_translator_unittest.cc
@@ -25,7 +25,6 @@ const char kUUID[] = "UUID-UUID-UUID";
// PpdReference test data
const char kUserSuppliedPpdUrl[] = "/some/path/to/user.url";
-const char kEffectiveManufacturer[] = "Ehch Pea";
const char kEffectiveModel[] = "PrintBlaster 2000";
TEST(PrinterTranslatorTest, PrefToPrinterMissingId) {
@@ -81,15 +80,12 @@ TEST(PrinterTranslatorTest, PrinterToPrefPpdReference) {
Printer printer("UNIQUE_ID");
auto* ppd = printer.mutable_ppd_reference();
ppd->user_supplied_ppd_url = kUserSuppliedPpdUrl;
- ppd->effective_manufacturer = kEffectiveManufacturer;
ppd->effective_model = kEffectiveModel;
std::unique_ptr<base::DictionaryValue> actual = PrinterToPref(printer);
base::ExpectDictStringValue(kUserSuppliedPpdUrl, *actual,
"ppd_reference.user_supplied_ppd_url");
- base::ExpectDictStringValue(kEffectiveManufacturer, *actual,
- "ppd_reference.effective_manufacturer");
base::ExpectDictStringValue(kEffectiveModel, *actual,
"ppd_reference.effective_model");
}
@@ -100,7 +96,6 @@ TEST(PrinterTranslatorTest, PrinterToPrefPpdReferenceLazy) {
std::unique_ptr<base::DictionaryValue> actual = PrinterToPref(printer);
EXPECT_FALSE(actual->HasKey("ppd_reference.user_supplied_ppd_url"));
- EXPECT_FALSE(actual->HasKey("ppd_reference.effective_manufacturer"));
EXPECT_FALSE(actual->HasKey("ppd_reference.effective_model"));
}
@@ -116,8 +111,6 @@ TEST(PrinterTranslatorTest, PrefToPrinterRoundTrip) {
preference.SetString("ppd_reference.user_supplied_ppd_url",
kUserSuppliedPpdUrl);
- preference.SetString("ppd_reference.effective_manufacturer",
- kEffectiveManufacturer);
preference.SetString("ppd_reference.effective_model", kEffectiveModel);
std::unique_ptr<Printer> printer = PrefToPrinter(preference);
« chromeos/printing/ppd_provider_unittest.cc ('K') | « chromeos/printing/printer_translator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698