[MD Bookmarks] Add Delete and Copy URL for Material Bookmarks.

chrome/browser/resources/md_bookmarks/store.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-store',
 
   properties: {
     /** @type {BookmarkTreeNode} */
     rootNode: {
@@ skipping 13 matching lines @@
       notify: true,
       readOnly: true,
     },
 
     idToNodeMap_: Object,
   },
 
   /** @private {Object} */
   documentListeners_: null,
 
+  /**
+   * Initializes the store with data from the bookmarks API.
+   * Called by app on attached.
+   */
+  initializeStore: function() {
+    chrome.bookmarks.getTree(function(results) {
+      this.setupStore_(results[0]);
+    }.bind(this));
+    chrome.bookmarks.onRemoved.addListener(this.onBookmarkRemoved_.bind(this));
+  },
+

[calamity, 2017/01/04 06:57:44]

Move this back to where it was.

[jiaxi, 2017/01/04 22:44:00]

Done.

   /** @override */
   attached: function() {
     this.documentListeners_ = {
       'selected-folder-changed': this.onSelectedFolderChanged_.bind(this),
       'folder-open-changed': this.onFolderOpenChanged_.bind(this),
     };
     for (var event in this.documentListeners_)
       document.addEventListener(event, this.documentListeners_[event]);
   },
 
   /** @override */
   detached: function() {
     for (var event in this.documentListeners_)
       document.removeEventListener(event, this.documentListeners_[event]);
   },
 
   /**
-   * Initializes the store with data from the bookmarks API.
-   * Called by app on attached.
-   */
-  initializeStore: function() {
-    chrome.bookmarks.getTree(function(results) {
-      this.setupStore_(results[0]);
-    }.bind(this));
-  },
-
-  /**
    * @param {BookmarkTreeNode} rootNode
    * @private
    */
   setupStore_: function(rootNode) {
     this.rootNode = rootNode;
     this.idToNodeMap_ = {};
     this.rootNode.path = 'rootNode';
+    this.generatePaths_(rootNode, 0);
     this.initNodes_(this.rootNode);
     this.fire('selected-folder-changed', this.rootNode.children[0].id);
   },
 
   /**
    * Selects the folder specified by the event and deselects the previously
    * selected folder.
    * @param {CustomEvent} e
    * @private
    */
@@ skipping 30 matching lines @@
   },
 
   /** @private */
   updateSelectedNode_: function() {
     var selectedNode = this.idToNodeMap_[this.selectedId];
     this.linkPaths('selectedNode', selectedNode.path);
     this._setSelectedNode(selectedNode);
   },
 
   /**
+   * Callback for when a bookmark node is removed.
+   * If a folder is selected or is an ancestor of a selected folder, the parent
+   * of the removed folder will be selected.
+   * @param {string} id The id of the removed bookmark node.
+   * @param {!Object} removeInfo
+   */
+  onBookmarkRemoved_: function(id, removeInfo) {
+    if (this.isAncestorOfSelected_(this.idToNodeMap_[id]))
+      this.fire('selected-folder-changed', removeInfo.parentId);

[calamity, 2017/01/04 06:57:44]

nit: newline

[jiaxi, 2017/01/04 22:44:00]

Done.

+    var parentNode = this.idToNodeMap_[removeInfo.parentId];
+    this.splice(parentNode.path + '.children', removeInfo.index, 1);
+    this.removeChildrenFromMap_(id);
+    this.generatePaths_(parentNode, Number(removeInfo.index));
+  },
+
+  /**
    * Initializes the nodes in the bookmarks tree as follows:
    * - Populates |idToNodeMap_| with a mapping of all node ids to their
    *   corresponding BookmarkTreeNode.
-   * - Stores the path from the store to a node inside the node.
    * - Sets all the nodes to not selected and open by default.
    * @param {BookmarkTreeNode} bookmarkNode
    * @private
    */
   initNodes_: function(bookmarkNode) {
     this.idToNodeMap_[bookmarkNode.id] = bookmarkNode;
     if (bookmarkNode.url)
       return;
 
     bookmarkNode.isSelected = false;
     bookmarkNode.isOpen = true;
     for (var i = 0; i < bookmarkNode.children.length; i++) {
-      bookmarkNode.children[i].path = bookmarkNode.path + '.children.' + i;
+      bookmarkNode.children[i].isSelected = false;
+      bookmarkNode.isOpen = true;
       this.initNodes_(bookmarkNode.children[i]);
     }
   },
+
+  /**
+   * Stores the path from the store to a node inside the node.
+   * @param {BookmarkTreeNode} bookmarkNode
+   * @param {number} startIndex
+   * @private
+   */
+  generatePaths_: function(bookmarkNode, startIndex) {
+    if (bookmarkNode.children) {

[calamity, 2017/01/04 06:57:44]

Invert and early return.

[jiaxi, 2017/01/04 22:44:00]

I think the early return is in this(https://codereview.appspot.com/315240043/)
patch, do you think I should do it in the current patch as well?

[calamity, 2017/01/05 07:07:08]

You might as well, the next patch will just pull it cleanly.

+      for (var i = startIndex; i < bookmarkNode.children.length; i++) {
+        bookmarkNode.children[i].path = bookmarkNode.path + '.children.#' + i;
+        this.generatePaths_(bookmarkNode.children[i], 0);
+      }
+    }
+  },
+
+  /**

[calamity, 2017/01/04 06:57:44]

This method deserves a comment.

[jiaxi, 2017/01/04 22:44:00]

Done.

+   * @param {string} id
+   * @private
+   */
+  removeChildrenFromMap_: function(id) {

[calamity, 2017/01/04 06:57:44]

Since this is all recursive children, I would prefer removeDescendantsFromMap_.

[jiaxi, 2017/01/04 22:44:00]

Done.

+    var node = this.idToNodeMap_[id];
+    if (!node)
+      return;
+
+    if (node.children) {
+      for (var i = 0; i < node.children.length; i++)
+        this.removeChildrenFromMap_(node.children[i].id);
+    }
+    delete this.idToNodeMap_[id];
+  }
 });