third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js - Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects. (Closed)

Patch Set: review comments addressed. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

index 4f17a9f311c96c7a3d7e305b5586e0e75272d380..65afbb28198ae064cd13dfae210a9793d2115167 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

@@ -322,6 +322,8 @@ Bindings.BlackboxManager = class {

* @return {!Promise<undefined>}

_addScript(script) {

+ if (!script.sourceURL && !script.sourceMapURL)

+ return Promise.resolve();

var blackboxed = this._isBlackboxedScript(script);

return this._setScriptState(script, blackboxed ? [{lineNumber: 0, columnNumber: 0}] : []);

}