third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html - Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

Issue 2613643002: DevTools: migrate from external Maps to symbols in the bindings objects. (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/callstack-placards-discarded.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

diff --git a/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html b/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

index 4f09e840340ad13bd6c07cd3618eb010b6bc4632..2aee4b3606c59641ec5e47ff8912405812415217 100644

--- a/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

+++ b/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

@@ -24,8 +24,9 @@ function test()

{

var content = uiSourceCode._content;

var revisionsString = "";

- for (var i = 0; i < uiSourceCode.history.length; ++i) {

- var revision = uiSourceCode.history[i];

+ var history = uiSourceCode.history();

+ for (var i = 0; i < history.length; ++i) {

+ var revision = history[i];

if (i !== 0)

revisionsString += ", ";

revisionsString += "'" + revision.content + "'";

@@ -102,7 +103,7 @@ function test()

InspectorTest.addResult("Second revision added.");

dumpUISourceCodeWithRevisions(uiSourceCode);

- uiSourceCode.history[0].revertToThis().then(onReverted);

+ uiSourceCode.history()[0].revertToThis().then(onReverted);

function onReverted()

{

@@ -197,7 +198,7 @@ function test()

InspectorTest.addResult("Second revision added.");

dumpUISourceCodeWithRevisions(uiSourceCode);

- uiSourceCode.history[0].revertToThis().then(onReverted);

+ uiSourceCode.history()[0].revertToThis().then(onReverted);

function onReverted()

{