content/browser/web_contents/web_contents_impl.cc - Issue 261363002: Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 261363002: Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_cleanupguestmanager

Patch Set: Addressed nits Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/test_guest_manager.cc ('K') | « content/browser/download/download_manager_impl_unittest.cc ('k') | content/content_browser.gypi » ('j') | content/public/browser/browser_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 34059689dacd2d1dbdcf223f2c5ed0c1b8a085c9..4720e580dcc9094a32361af2390ea4407602382c 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -57,7 +57,7 @@

#include "content/common/view_messages.h"

#include "content/public/browser/ax_event_notification_details.h"

#include "content/public/browser/browser_context.h"

-#include "content/public/browser/browser_plugin_guest_manager_delegate.h"

+#include "content/public/browser/browser_plugin_guest_manager.h"

#include "content/public/browser/content_browser_client.h"

#include "content/public/browser/devtools_agent_host.h"

#include "content/public/browser/download_manager.h"

@@ -1417,7 +1417,7 @@ void WebContentsImpl::CreateNewWindow(

// This makes |new_contents| act as a guest.

// For more info, see comment above class BrowserPluginGuest.

int instance_id =

- GetBrowserContext()->GetGuestManagerDelegate()->GetNextInstanceID();

+ GetBrowserContext()->GetGuestManager()->GetNextInstanceID();

WebContentsImpl* new_contents_impl =

static_cast<WebContentsImpl*>(new_contents);

BrowserPluginGuest::CreateWithOpener(instance_id,