Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: content/browser/browser_plugin/test_guest_manager.cc

Issue 261363002: Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_cleanupguestmanager
Patch Set: Addressed nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/test_guest_manager.cc
diff --git a/content/browser/browser_plugin/test_guest_manager_delegate.cc b/content/browser/browser_plugin/test_guest_manager.cc
similarity index 86%
rename from content/browser/browser_plugin/test_guest_manager_delegate.cc
rename to content/browser/browser_plugin/test_guest_manager.cc
index 5b29914f38c67a3720bf1f9fa3260b3942a95f4d..baa9c572205e8edc49a697f6d9c1c84dae62c2a2 100644
--- a/content/browser/browser_plugin/test_guest_manager_delegate.cc
+++ b/content/browser/browser_plugin/test_guest_manager.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/browser_plugin/test_guest_manager_delegate.h"
+#include "content/browser/browser_plugin/test_guest_manager.h"
#include "base/logging.h"
#include "base/memory/singleton.h"
@@ -30,7 +30,7 @@ class GuestWebContentsObserver
}
virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE {
- TestGuestManagerDelegate::GetInstance()->RemoveGuest(guest_instance_id_);
+ TestGuestManager::GetInstance()->RemoveGuest(guest_instance_id_);
delete this;
}
@@ -39,20 +39,20 @@ class GuestWebContentsObserver
DISALLOW_COPY_AND_ASSIGN(GuestWebContentsObserver);
};
-TestGuestManagerDelegate::TestGuestManagerDelegate()
+TestGuestManager::TestGuestManager()
: last_guest_added_(NULL),
next_instance_id_(0) {
}
-TestGuestManagerDelegate::~TestGuestManagerDelegate() {
+TestGuestManager::~TestGuestManager() {
}
// static.
-TestGuestManagerDelegate* TestGuestManagerDelegate::GetInstance() {
- return Singleton<TestGuestManagerDelegate>::get();
+TestGuestManager* TestGuestManager::GetInstance() {
+ return Singleton<TestGuestManager>::get();
}
-WebContentsImpl* TestGuestManagerDelegate::WaitForGuestAdded() {
+WebContentsImpl* TestGuestManager::WaitForGuestAdded() {
// Check if guests were already created.
if (last_guest_added_) {
WebContentsImpl* last_guest_added = last_guest_added_;
@@ -67,7 +67,7 @@ WebContentsImpl* TestGuestManagerDelegate::WaitForGuestAdded() {
return last_guest_added;
}
-content::WebContents* TestGuestManagerDelegate::CreateGuest(
+content::WebContents* TestGuestManager::CreateGuest(
SiteInstance* embedder_site_instance,
int instance_id,
const std::string& storage_partition_id,
@@ -105,11 +105,11 @@ content::WebContents* TestGuestManagerDelegate::CreateGuest(
return guest_web_contents;
}
-int TestGuestManagerDelegate::GetNextInstanceID() {
+int TestGuestManager::GetNextInstanceID() {
return ++next_instance_id_;
}
-void TestGuestManagerDelegate::AddGuest(
+void TestGuestManager::AddGuest(
int guest_instance_id,
WebContents* guest_web_contents) {
DCHECK(guest_web_contents_by_instance_id_.find(guest_instance_id) ==
@@ -121,7 +121,7 @@ void TestGuestManagerDelegate::AddGuest(
message_loop_runner_->Quit();
}
-void TestGuestManagerDelegate::RemoveGuest(
+void TestGuestManager::RemoveGuest(
int guest_instance_id) {
GuestInstanceMap::iterator it =
guest_web_contents_by_instance_id_.find(guest_instance_id);
@@ -129,7 +129,7 @@ void TestGuestManagerDelegate::RemoveGuest(
guest_web_contents_by_instance_id_.erase(it);
}
-void TestGuestManagerDelegate::MaybeGetGuestByInstanceIDOrKill(
+void TestGuestManager::MaybeGetGuestByInstanceIDOrKill(
int guest_instance_id,
int embedder_render_process_id,
const GuestByInstanceIDCallback& callback) {
@@ -142,7 +142,7 @@ void TestGuestManagerDelegate::MaybeGetGuestByInstanceIDOrKill(
callback.Run(it->second);
}
-SiteInstance* TestGuestManagerDelegate::GetGuestSiteInstance(
+SiteInstance* TestGuestManager::GetGuestSiteInstance(
const GURL& guest_site) {
for (GuestInstanceMap::const_iterator it =
guest_web_contents_by_instance_id_.begin();
@@ -153,7 +153,7 @@ SiteInstance* TestGuestManagerDelegate::GetGuestSiteInstance(
return NULL;
}
-bool TestGuestManagerDelegate::ForEachGuest(
+bool TestGuestManager::ForEachGuest(
WebContents* embedder_web_contents,
const GuestCallback& callback) {
for (GuestInstanceMap::iterator it =

Powered by Google App Engine
This is Rietveld 408576698