Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2613623002: media: Continue aborting FFMpegDemuxerStream::Read() calls until Seek(). (Closed)

Created:
3 years, 11 months ago by sandersd (OOO until July 31)
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

media: Continue aborting FFMpegDemuxerStream::Read() calls until Seek(). For decoders that support multiple in-flight decodes (ie. GpuVideoDecoder), it was possible to schedule a Read() after AbortPendingReads() but before Seek() was called. These reads were satisfied with data that decoders were not expecting (because the aborted buffers were fully dropped, there were gaps in the input). Now AbortPendingReads() is defined to continue to abort Read()s until Seek(), which solves the problem. ChunkDemuxer was already implementing this behavior, so only FFmpegDemuxer requires changes. BUG=667210 Review-Url: https://codereview.chromium.org/2546263002 Cr-Commit-Position: refs/heads/master@{#436428} (cherry picked from commit 216002cff0b287035a57cacc510419e15e5217c9) TBR=dalecurtis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3131222425a01a6b46f7e19f47b938200fda807d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M media/base/demuxer.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sandersd (OOO until July 31)
3 years, 11 months ago (2017-01-03 22:29:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3131222425a01a6b46f7e19f47b938200fda807d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698