Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: skia/ext/platform_canvas.cc

Issue 2613583002: Remove skia::ScopedPlatformPaint (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/platform_canvas.h ('k') | skia/ext/platform_canvas_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/platform_canvas.cc
diff --git a/skia/ext/platform_canvas.cc b/skia/ext/platform_canvas.cc
index 52a11c7b47ea03e92f20b882ba827b070e336b9a..81093801b624444181ea03b5f8e11f292fa27d06 100644
--- a/skia/ext/platform_canvas.cc
+++ b/skia/ext/platform_canvas.cc
@@ -90,18 +90,17 @@ bool IsPreviewMetafile(const SkCanvas& canvas) {
}
#endif
-ScopedPlatformPaint::ScopedPlatformPaint(SkCanvas* canvas) :
- canvas_(canvas),
- native_drawing_context_(nullptr) {
- // TODO(tomhudson) we're assuming non-null canvas?
+NativeDrawingContext GetNativeDrawingContext(SkCanvas* canvas) {
PlatformDevice* platform_device = GetPlatformDevice(canvas->getTopDevice(true));
- if (platform_device) {
- // Compensate for drawing to a layer rather than the entire canvas
- SkMatrix ctm;
- SkIRect clip_bounds;
- canvas->temporary_internal_describeTopLayer(&ctm, &clip_bounds);
- native_drawing_context_ = platform_device->BeginPlatformPaint(ctm, clip_bounds);
- }
+ if (!platform_device)
+ return nullptr;
+
+ // Compensate for drawing to a layer rather than the entire canvas
+ SkMatrix ctm;
+ SkIRect clip_bounds;
+ canvas->temporary_internal_describeTopLayer(&ctm, &clip_bounds);
+
+ return platform_device->BeginPlatformPaint(ctm, clip_bounds);
}
} // namespace skia
« no previous file with comments | « skia/ext/platform_canvas.h ('k') | skia/ext/platform_canvas_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698