Issue 26134002: Add *CSS* prefix to FontValue and FontFeatureValue

Issue 26134002: Add CSS prefix to FontValue and FontFeatureValue (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add *CSS* prefix to FontValue and FontFeatureValue To generate toCSSFontValue() and toCSSFontFeatureValue(), this cl needs to add *CSS* prefix to FontValue and FontFeatureValue. It is also to be consistent with existing other CSSFooValue naming style. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159011

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -290 lines)			Patch
M	Source/core/core.gypi	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
A +	Source/core/css/CSSFontFeatureValue.h	View		1 chunk	+9 lines, -7 lines	0 comments	Download
A +	Source/core/css/CSSFontFeatureValue.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	Source/core/css/CSSFontValue.h	View		3 chunks	+9 lines, -7 lines	0 comments	Download
A +	Source/core/css/CSSFontValue.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	1	5 chunks	+8 lines, -8 lines	0 comments	Download
D	Source/core/css/FontFeatureValue.h	View		1 chunk	+0 lines, -56 lines	0 comments	Download
D	Source/core/css/FontFeatureValue.cpp	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	Source/core/css/FontValue.h	View		1 chunk	+0 lines, -60 lines	0 comments	Download
D	Source/core/css/FontValue.cpp	View		1 chunk	+0 lines, -77 lines	0 comments	Download
M	Source/core/css/resolver/FontBuilder.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/26134002/diff/3001/Source/core/css/CSSValue.cpp File Source/core/css/CSSValue.cpp (right): https://codereview.chromium.org/26134002/diff/3001/Source/core/css/CSSValue.cpp#newcode252 Source/core/css/CSSValue.cpp:252: return static_cast<const CSSFontValue*>(this)->customCssText(); Should use toCSSFontValue() https://codereview.chromium.org/26134002/diff/3001/Source/core/css/CSSValue.cpp#newcode256 Source/core/css/CSSValue.cpp:256: return ...

7 years, 2 months ago (2013-10-06 22:41:50 UTC) #2

gyuyoung-inactive

https://chromiumcodereview.appspot.com/26134002/diff/3001/Source/core/css/CSSValue.cpp File Source/core/css/CSSValue.cpp (right): https://chromiumcodereview.appspot.com/26134002/diff/3001/Source/core/css/CSSValue.cpp#newcode252 Source/core/css/CSSValue.cpp:252: return static_cast<const CSSFontValue*>(this)->customCssText(); On 2013/10/06 22:41:50, tkent wrote: > ...

7 years, 2 months ago (2013-10-07 05:22:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/26134002/9001

7 years, 2 months ago (2013-10-07 05:27:44 UTC) #5

Message was sent while issue was closed.

Change committed as 159011

Expand Messages | Collapse Messages