Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: media/base/audio_buffer_unittest.cc

Issue 261333002: Fix AudioBuffer verification tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_buffer_queue_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_buffer_unittest.cc
diff --git a/media/base/audio_buffer_unittest.cc b/media/base/audio_buffer_unittest.cc
index c0fbf6b85befa1c79a3ed401363e44ced0d341bf..039dc0af3cde049bb05c10e3f27d9f60636b07ff 100644
--- a/media/base/audio_buffer_unittest.cc
+++ b/media/base/audio_buffer_unittest.cc
@@ -11,15 +11,15 @@ namespace media {
static const int kSampleRate = 48000;
-
static void VerifyBusWithOffset(AudioBus* bus,
int offset,
int frames,
float start,
+ float start_offset,
float increment) {
for (int ch = 0; ch < bus->channels(); ++ch) {
- const float v = start + ch * bus->frames() * increment;
- for (int i = offset; i < frames; ++i) {
+ const float v = start_offset + start + ch * bus->frames() * increment;
+ for (int i = offset; i < offset + frames; ++i) {
ASSERT_FLOAT_EQ(v + i * increment, bus->channel(ch)[i]) << "i=" << i
<< ", ch=" << ch;
}
@@ -27,7 +27,7 @@ static void VerifyBusWithOffset(AudioBus* bus,
}
static void VerifyBus(AudioBus* bus, int frames, float start, float increment) {
- VerifyBusWithOffset(bus, 0, frames, start, increment);
+ VerifyBusWithOffset(bus, 0, frames, start, 0, increment);
}
static void TrimRangeTest(SampleFormat sample_format) {
@@ -65,8 +65,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, 0, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ 0,
+ trim_length,
+ 1);
// Trim 10ms of frames from the start, which just adjusts the buffer's
// internal start offset.
@@ -78,8 +82,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, trim_length, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ trim_length,
+ trim_length,
+ 1);
// Trim 10ms of frames from the end, which just adjusts the buffer's frame
// count.
@@ -90,8 +98,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, trim_length, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ trim_length,
+ trim_length,
+ 1);
// Trim another 10ms from the inner portion of the buffer.
buffer->TrimRange(trim_start, trim_start + trim_length);
@@ -101,8 +113,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, trim_length, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ trim_length,
+ trim_length * 2,
+ 1);
// Trim off the end using TrimRange() to ensure end index is exclusive.
buffer->TrimRange(buffer->frame_count() - trim_length, buffer->frame_count());
@@ -112,8 +128,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, trim_length, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ trim_length,
+ trim_length * 2,
+ 1);
// Trim off the start using TrimRange() to ensure start index is inclusive.
buffer->TrimRange(0, trim_length);
@@ -124,8 +144,12 @@ static void TrimRangeTest(SampleFormat sample_format) {
bus->Zero();
buffer->ReadFrames(buffer->frame_count(), 0, 0, bus.get());
VerifyBus(bus.get(), trim_start, 2 * trim_length, 1);
- VerifyBusWithOffset(
- bus.get(), trim_start, buffer->frame_count() - trim_start, 0, 1);
+ VerifyBusWithOffset(bus.get(),
+ trim_start,
+ buffer->frame_count() - trim_start,
+ trim_length * 2,
+ trim_length * 2,
+ 1);
}
TEST(AudioBufferTest, CopyFrom) {
« no previous file with comments | « media/base/audio_buffer_queue_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698