Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: media/base/audio_buffer_queue_unittest.cc

Issue 261333002: Fix AudioBuffer verification tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/audio_buffer_unittest.cc » ('j') | media/base/audio_buffer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_buffer_queue_unittest.cc
diff --git a/media/base/audio_buffer_queue_unittest.cc b/media/base/audio_buffer_queue_unittest.cc
index e6a148ae21bba7940e71e12a70989b4451f1cfdf..dfb2098e1aa29bcec87bec6bf1705e5c16b192a0 100644
--- a/media/base/audio_buffer_queue_unittest.cc
+++ b/media/base/audio_buffer_queue_unittest.cc
@@ -25,7 +25,7 @@ static void VerifyBus(AudioBus* bus,
float increment) {
for (int ch = 0; ch < bus->channels(); ++ch) {
const float v = start + ch * buffer_size * increment;
- for (int i = offset; i < frames; ++i) {
+ for (int i = offset; i < offset + frames; ++i) {
ASSERT_FLOAT_EQ(v + (i - offset) * increment, bus->channel(ch)[i])
<< "i=" << i << ", ch=" << ch;
}
@@ -274,8 +274,8 @@ TEST(AudioBufferQueueTest, ReadS16Planar) {
// Add 24 frames of data.
buffer.Append(
MakeTestBuffer<int16>(kSampleFormatPlanarS16, channel_layout, 1, 1, 4));
- buffer.Append(MakeTestBuffer<int16>(
- kSampleFormatPlanarS16, channel_layout, 100, 5, 20));
+ buffer.Append(
+ MakeTestBuffer<int16>(kSampleFormatPlanarS16, channel_layout, 5, 1, 20));
EXPECT_EQ(24, buffer.frames());
// Read 6 frames from the buffer.
« no previous file with comments | « no previous file | media/base/audio_buffer_unittest.cc » ('j') | media/base/audio_buffer_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698