Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2613283002: Fuchsia: Use new call to get thread CPU time (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Small fix #

Total comments: 2

Patch Set 3 : Delete dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -106 lines) Patch
M runtime/bin/run_vm_tests_fuchsia.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/bin/thread.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/thread_android.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/bin/thread_fuchsia.cc View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M runtime/bin/thread_linux.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/bin/thread_macos.cc View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/bin/thread_win.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-06 17:41:26 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/2613283002/diff/20001/runtime/bin/thread_fuchsia.cc File runtime/bin/thread_fuchsia.cc (right): https://codereview.chromium.org/2613283002/diff/20001/runtime/bin/thread_fuchsia.cc#newcode170 runtime/bin/thread_fuchsia.cc:170: void Thread::GetThreadCpuUsage(ThreadId thread_id, int64_t* cpu_usage) { bin::Thread::GetThreadCpuUsage ...
3 years, 11 months ago (2017-01-06 18:34:24 UTC) #3
zra
https://codereview.chromium.org/2613283002/diff/20001/runtime/bin/thread_fuchsia.cc File runtime/bin/thread_fuchsia.cc (right): https://codereview.chromium.org/2613283002/diff/20001/runtime/bin/thread_fuchsia.cc#newcode170 runtime/bin/thread_fuchsia.cc:170: void Thread::GetThreadCpuUsage(ThreadId thread_id, int64_t* cpu_usage) { On 2017/01/06 18:34:24, ...
3 years, 11 months ago (2017-01-07 22:45:17 UTC) #4
zra
3 years, 11 months ago (2017-01-07 22:45:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9b8ce83ef3c0c612462251968c816994591d9278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698