Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/drive/chromeos/file_system/search_operation.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Add a TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/drive/chromeos/fake_file_system.cc ('K') | « components/drive/chromeos/fake_file_system.cc ('k') | components/drive/drive_app_registry.cc » ('j') | components/drive/drive_app_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/drive/chromeos/file_system/search_operation.cc
diff --git a/components/drive/chromeos/file_system/search_operation.cc b/components/drive/chromeos/file_system/search_operation.cc
index a2608c3f4149251d42b87e9886886981cd143f9f..331e6cd54ab330d9a7e7813f1e391f27161bac0c 100644
--- a/components/drive/chromeos/file_system/search_operation.cc
+++ b/components/drive/chromeos/file_system/search_operation.cc
@@ -37,7 +37,8 @@ FileError ResolveSearchResultOnBlockingPool(
DCHECK(resource_metadata);
DCHECK(result);
- const ScopedVector<google_apis::FileResource>& entries = file_list->items();
+ const std::vector<std::unique_ptr<google_apis::FileResource>>& entries =
hidehiko 2017/01/10 06:44:36 Ditto for include <memory>
leonhsl(Using Gerrit) 2017/01/10 09:48:13 Done.
+ file_list->items();
result->reserve(entries.size());
for (size_t i = 0; i < entries.size(); ++i) {
std::string local_id;
« components/drive/chromeos/fake_file_system.cc ('K') | « components/drive/chromeos/fake_file_system.cc ('k') | components/drive/drive_app_registry.cc » ('j') | components/drive/drive_app_registry.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698