Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: components/drive/chromeos/change_list_processor.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Add a TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/drive/chromeos/change_list_processor.cc
diff --git a/components/drive/chromeos/change_list_processor.cc b/components/drive/chromeos/change_list_processor.cc
index ab2f3bdd22b03e6ff1834e15cfcd087286ae551b..f40faf7a4022ad86c2c92a6afaf47f93e20b9ede 100644
--- a/components/drive/chromeos/change_list_processor.cc
+++ b/components/drive/chromeos/change_list_processor.cc
@@ -71,7 +71,8 @@ ChangeList::ChangeList() {}
ChangeList::ChangeList(const google_apis::ChangeList& change_list)
: next_url_(change_list.next_link()),
largest_changestamp_(change_list.largest_change_id()) {
- const ScopedVector<google_apis::ChangeResource>& items = change_list.items();
+ const std::vector<std::unique_ptr<google_apis::ChangeResource>>& items =
hidehiko 2017/01/10 06:44:36 Could you include <vector> and <memory> ?
leonhsl(Using Gerrit) 2017/01/10 09:48:13 Done.
+ change_list.items();
entries_.resize(items.size());
parent_resource_ids_.resize(items.size());
size_t entries_index = 0;
@@ -90,7 +91,8 @@ ChangeList::ChangeList(const google_apis::ChangeList& change_list)
ChangeList::ChangeList(const google_apis::FileList& file_list)
: next_url_(file_list.next_link()),
largest_changestamp_(0) {
- const ScopedVector<google_apis::FileResource>& items = file_list.items();
+ const std::vector<std::unique_ptr<google_apis::FileResource>>& items =
+ file_list.items();
entries_.resize(items.size());
parent_resource_ids_.resize(items.size());
size_t entries_index = 0;

Powered by Google App Engine
This is Rietveld 408576698