chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc - Issue 2613223002: Remove ScopedVector from base::JSONValueConverter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)

Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

index 217b592c5f5126f1c467cbd8fb1800e2a88541bd..657807999b7ece55f04b579c6916057b3be4b45f 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

@@ -54,13 +54,13 @@ std::unique_ptr<DatabaseContents> CreateTestDatabaseContents() {

test_util::CreatePlaceholderTracker(

"unsynced_file_id", kPlaceholderTrackerID, app_root_tracker.get());

- contents->file_metadata.push_back(sync_root_metadata.release());

- contents->file_trackers.push_back(sync_root_tracker.release());

- contents->file_metadata.push_back(app_root_metadata.release());

- contents->file_trackers.push_back(app_root_tracker.release());

- contents->file_metadata.push_back(file_metadata.release());

- contents->file_trackers.push_back(file_tracker.release());

- contents->file_trackers.push_back(placeholder_tracker.release());

+ contents->file_metadata.push_back(std::move(sync_root_metadata));

+ contents->file_trackers.push_back(std::move(sync_root_tracker));

+ contents->file_metadata.push_back(std::move(app_root_metadata));

+ contents->file_trackers.push_back(std::move(app_root_tracker));

+ contents->file_metadata.push_back(std::move(file_metadata));

+ contents->file_trackers.push_back(std::move(file_tracker));

+ contents->file_trackers.push_back(std::move(placeholder_tracker));

return contents;

}