Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/list_changes_task.h

Issue 2613223002: Remove ScopedVector from base::JSONValueConverter (Closed)
Patch Set: Rebase and address comments from mmenke@ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_ 5 #ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_
6 #define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_ 6 #define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 11
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/memory/scoped_vector.h"
14 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
15 #include "chrome/browser/sync_file_system/drive_backend/sync_task.h" 14 #include "chrome/browser/sync_file_system/drive_backend/sync_task.h"
16 #include "google_apis/drive/drive_api_error_codes.h" 15 #include "google_apis/drive/drive_api_error_codes.h"
17 16
18 namespace drive { 17 namespace drive {
19 class DriveServiceInterface; 18 class DriveServiceInterface;
20 } 19 }
21 20
22 namespace google_apis { 21 namespace google_apis {
23 class ChangeList; 22 class ChangeList;
(...skipping 19 matching lines...) Expand all
43 google_apis::DriveApiErrorCode error, 42 google_apis::DriveApiErrorCode error,
44 std::unique_ptr<google_apis::ChangeList> change_list); 43 std::unique_ptr<google_apis::ChangeList> change_list);
45 void CheckInChangeList(int64_t largest_change_id, 44 void CheckInChangeList(int64_t largest_change_id,
46 std::unique_ptr<SyncTaskToken> token); 45 std::unique_ptr<SyncTaskToken> token);
47 46
48 bool IsContextReady(); 47 bool IsContextReady();
49 MetadataDatabase* metadata_database(); 48 MetadataDatabase* metadata_database();
50 drive::DriveServiceInterface* drive_service(); 49 drive::DriveServiceInterface* drive_service();
51 50
52 SyncEngineContext* sync_context_; 51 SyncEngineContext* sync_context_;
53 ScopedVector<google_apis::ChangeResource> change_list_; 52 std::vector<std::unique_ptr<google_apis::ChangeResource>> change_list_;
54 53
55 std::vector<std::string> file_ids_; 54 std::vector<std::string> file_ids_;
56 55
57 base::WeakPtrFactory<ListChangesTask> weak_ptr_factory_; 56 base::WeakPtrFactory<ListChangesTask> weak_ptr_factory_;
58 57
59 DISALLOW_COPY_AND_ASSIGN(ListChangesTask); 58 DISALLOW_COPY_AND_ASSIGN(ListChangesTask);
60 }; 59 };
61 60
62 } // namespace drive_backend 61 } // namespace drive_backend
63 } // namespace sync_file_system 62 } // namespace sync_file_system
64 63
65 #endif // CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_ 64 #endif // CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_LIST_CHANGES_TASK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698