Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: appengine/findit/crash/loglinear/feature.py

Issue 2613153006: [Predator] Add TouchCrashedFileMetaFeature. (Closed)
Patch Set: Add comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/loglinear/feature.py
diff --git a/appengine/findit/crash/loglinear/feature.py b/appengine/findit/crash/loglinear/feature.py
index f1652373580b6450d75083b6dbed894e5c78268c..87159ab9d2d5ae0b49d7e23bb825ae72f4fc2ace 100644
--- a/appengine/findit/crash/loglinear/feature.py
+++ b/appengine/findit/crash/loglinear/feature.py
@@ -114,7 +114,8 @@ class FeatureValue(Element): # pragma: no cover
@property
def reason(self):
- return self._reason
+ return ('%s: %f -- %s' % (self._name, self._value, self._reason)
+ if self._reason else None)
@property
def changed_files(self):
@@ -197,9 +198,7 @@ class MetaFeatureValue(MetaDict):
formatted_reasons = []
for feature in self.itervalues():
if feature.reason:
- formatted_reasons.append('%s: %f -- %s' % (feature.name,
- feature.value,
- feature.reason))
+ formatted_reasons.append(feature.reason)
formatted_reasons.sort()
self._reason = '\n'.join(formatted_reasons)

Powered by Google App Engine
This is Rietveld 408576698