Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: tools/perf/benchmarks/loading.py

Issue 2613153005: Disable loading.mobile on Nexus6 WebView (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 import page_sets 6 import page_sets
7 7
8 import ct_benchmarks_util 8 import ct_benchmarks_util
9 from benchmarks import page_cycler_v2 9 from benchmarks import page_cycler_v2
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 12 matching lines...) Expand all
23 tbm_options = timeline_based_measurement.Options() 23 tbm_options = timeline_based_measurement.Options()
24 page_cycler_v2.AugmentOptionsForLoadingMetrics(tbm_options) 24 page_cycler_v2.AugmentOptionsForLoadingMetrics(tbm_options)
25 return tbm_options 25 return tbm_options
26 26
27 @classmethod 27 @classmethod
28 def ShouldDisable(cls, possible_browser): 28 def ShouldDisable(cls, possible_browser):
29 # crbug.com/619254 29 # crbug.com/619254
30 if possible_browser.browser_type == 'reference': 30 if possible_browser.browser_type == 'reference':
31 return True 31 return True
32 32
33 # crbug.com/676612
34 if ((possible_browser.platform.GetDeviceTypeName() == 'Nexus 6' or
35 possible_browser.platform.GetDeviceTypeName() == 'AOSP on Shamu') and
36 possible_browser.browser_type == 'android-webview'):
37 return True
38
33 return False 39 return False
34 40
35 @classmethod 41 @classmethod
36 def Name(cls): 42 def Name(cls):
37 return 'loading.mobile' 43 return 'loading.mobile'
38 44
39 def CreateStorySet(self, options): 45 def CreateStorySet(self, options):
40 return page_sets.LoadingMobileStorySet( 46 return page_sets.LoadingMobileStorySet(
41 cache_temperatures=[cache_temperature.ANY], 47 cache_temperatures=[cache_temperature.ANY],
42 traffic_settings=[traffic_setting.NONE, traffic_setting.REGULAR_3G]) 48 traffic_settings=[traffic_setting.NONE, traffic_setting.REGULAR_3G])
(...skipping 30 matching lines...) Expand all
73 help='Traffic condition (string). Default to "%%default". Can be: %s' % 79 help='Traffic condition (string). Default to "%%default". Can be: %s' %
74 ', '.join(cls._ALL_NET_CONFIGS)) 80 ', '.join(cls._ALL_NET_CONFIGS))
75 81
76 def CreateStorySet(self, options): 82 def CreateStorySet(self, options):
77 def Wait(action_runner): 83 def Wait(action_runner):
78 action_runner.Wait(options.wait_time) 84 action_runner.Wait(options.wait_time)
79 return page_sets.CTPageSet( 85 return page_sets.CTPageSet(
80 options.urls_list, options.user_agent, options.archive_data_file, 86 options.urls_list, options.user_agent, options.archive_data_file,
81 traffic_setting=options.traffic_setting, 87 traffic_setting=options.traffic_setting,
82 run_page_interaction_callback=Wait) 88 run_page_interaction_callback=Wait)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698